fix: Optimize environ.rs to avoid redundant string allocations #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Used HashSet<Modifier> instead of Vec for faster checks 2. Removed unnecessary .clone() calls 3. Replaced manual iterations over modifiers with HashSet ordered comparisons. 4. Instead of looping manually to unbind, use .extend() 5. Modified the test to account for the changes above
This commit makes `environ.rs` more optimized by removing redundant `.to_string()` allocations by using Cow (copy-on-write). 1. Used filter_map for single pass instead of manual iteration through env.lines() 2. Replace most .to_string() with Cow to remove unnecessary string allocations 3. In `construct` function, used `env::vars.collect()` to get all values in one pass instead of allocation new string, also now returns env::vars by default instead of an empty HashMap<String, String>
Contributor
Author
|
Ah maybe should have created a new fork |
Shinyzenith
approved these changes
Mar 23, 2025
Member
Shinyzenith
left a comment
Shinyzenith
left a comment
There was a problem hiding this comment.
Looks mostly fine to me. @newtoallofthis123 can you check once too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes
environ.rsmore optimized by removing redundant.to_string()allocations by using borrow::Cow (copy-on-write).Used filter_map for single pass instead of manual iteration through
env.lines()
Replace most .to_string() with Cow to remove unnecessary string
allocations
In
constructfunction, usedenv::vars.collect()to get all valuesin one pass instead of allocation new string, also now returns
env::varsby default instead of an empty
HashMap<String, String>.Add some comments for more readability.
This PR was tested with:
make check make testI did not create any new functions so NO tests were added or modified.