feat(core): allow array of ids as updateNodeInternals arg#3007
Conversation
|
thanks @bcakmakoglu! Couldn't we wrap the for each with one |
|
Yeah, didn't think of that 😅 |
|
|
||
| requestAnimationFrame(() => { | ||
| updateIds.forEach((id) => { | ||
| updateNodeDimensions([{ id, nodeElement, forceUpdate: true }]); |
There was a problem hiding this comment.
the nodeElement would always be the same node. You also need to call domNode?.querySelector... multiple times. It's also possible to pass an array with ids and nodeElements to updateNodeDimensions.
There was a problem hiding this comment.
Ah yeah, that makes sense - I'll change that
Thanks for keeping an eye out, I didn't think too much doing this PR and it shows 🤣
There was a problem hiding this comment.
querySelector should go in the forEach so that nodeElement matches the actual node.
|
|
||
| requestAnimationFrame(() => { | ||
| updateIds.forEach((id) => { | ||
| updateNodeDimensions([{ id, nodeElement, forceUpdate: true }]); |
There was a problem hiding this comment.
querySelector should go in the forEach so that nodeElement matches the actual node.
6cf8e47 to
80e586f
Compare
|
Thanks @bcakmakoglu 🙌 |
2 participants
What's changed?
updateNodeInternals