fix: send CancelHistoricalData when streaming subscription is dropped#430
Merged
fix: send CancelHistoricalData when streaming subscription is dropped#430
Conversation
…#427) historical_data_streaming used send_raw bypassing the Subscription<T> cancel-on-drop mechanism. Added encode_cancel_historical_data encoder and wired both async/sync HistoricalDataStreamingSubscription to send the cancel message on drop.
wboayue
force-pushed
the
fix/427-cancel-historical-data-streaming
branch
from
5f5ad98 to
edafe23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
historical_data_streamingsubscriptions now sendCancelHistoricalDatato the server when dropped or explicitly cancelledencode_cancel_historical_dataencoder (message type 25, version 1, request_id)HistoricalDataStreamingSubscriptionwithrequest_id,message_bus, andcancelledflagDropusestokio::spawnto send the cancel message; syncDropdelegates tocancel()cancel()followed by drop only sends one cancel messageTest plan
test_encode_cancel_historical_data— verifies encoder outputtest_streaming_subscription_sends_cancel_on_drop(async + sync) — verifies cancel message sent on droptest_streaming_subscription_cancel_prevents_duplicate_on_drop(async + sync) — verifies idempotency