cleanup: move MW DB Version Map to config file #1014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deer-wmde
changed the title
deer-wmde
changed the title
outdooracorn
approved these changes
Nov 25, 2025
Member
outdooracorn
left a comment
outdooracorn
left a comment
There was a problem hiding this comment.
LGTM! Left one optional nitpick
Comment on lines
+4
to
+9
| $versionMap = [ | ||
| 'mw1.39-wbs1' => '139', | ||
| 'mw1.43-wbs1' => '143', | ||
| ]; | ||
|
|
||
| return $versionMap; |
Member
There was a problem hiding this comment.
[non-blocking nitpick]: no need for a variable?
Suggested change
| $versionMap = [ | |
| 'mw1.39-wbs1' => '139', | |
| 'mw1.43-wbs1' => '143', | |
| ]; | |
| return $versionMap; | |
| return [ | |
| 'mw1.39-wbs1' => '139', | |
| 'mw1.43-wbs1' => '143', | |
| ]; |
Contributor
Author
There was a problem hiding this comment.
I assume we might benefit from it when we will add code to read this from somewhere elseTM in the future (or when we want to figure out how that could work & look like)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reduce steps necessary for a MW update I believe we should define this magical map at one place only.
TODO: