Conversation
This commit multiplies by 5 the rate at which we prune events. Given our long term average prune rate and remaining EventPageUpdates this should be fast enough to keep us pruning to the 100k level we're targeting
m90
approved these changes
Sep 19, 2023
Contributor
m90
left a comment
m90
left a comment
There was a problem hiding this comment.
Sounds sensible to me, although we might want to make this configurable at some point instead of hardcoding the value maybe?
Contributor
Author
|
yeah, I agree we really might want to do that. I think the second time we need to change these (even if it's in the next 24hrs) we should |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit multiplies by 5 the rate at which we prune events.
Given our long term average prune rate and remaining EventPageUpdates this should be fast enough to keep us pruning to the 100k level we're targeting