feat: Create EmptyWikibaseNotification Model and Notification#656
Merged
Conversation
m90
reviewed
Oct 11, 2023
m90
reviewed
Nov 2, 2023
m90
reviewed
Nov 2, 2023
m90
reviewed
Nov 2, 2023
m90
reviewed
Nov 2, 2023
m90
reviewed
Nov 2, 2023
m90
reviewed
Nov 9, 2023
m90
reviewed
Nov 9, 2023
m90
reviewed
Nov 9, 2023
m90
reviewed
Nov 13, 2023
m90
reviewed
Nov 13, 2023
m90
reviewed
Nov 13, 2023
m90
reviewed
Nov 13, 2023
m90
reviewed
Nov 13, 2023
m90
reviewed
Nov 13, 2023
m90
reviewed
Nov 14, 2023
Contributor
m90
left a comment
m90
left a comment
There was a problem hiding this comment.
Looks great now, I left one last round of comments, nothing major.
| $wikiManagers = $wiki->wikiManagers()->get(); | ||
|
|
||
| foreach($wikiManagers as $wikiManager) { | ||
| $wiki->wikiNotificationSentRecords()->create([ |
Contributor
There was a problem hiding this comment.
Like this, we'd also create a record when the notfiy call below fails immediately. Should we create the record after calling notify?
Contributor
There was a problem hiding this comment.
That's a great point but I'm not sure if that is the case since the notify method appears to dispatch the sending, but I'm not entirely sure how it all works in detail. My thinking was the other way around: prevent a case where we send a notification but don't keep a record, resulting in potentially spamming a user. But now I'm not sure how to prevent both cases
Contributor
There was a problem hiding this comment.
Hmm, if notify will only ever fail asynchronously, then your argument is valid and it should be kept in the order you put it here. Maybe it's worth a comment though?
m90
approved these changes
Nov 14, 2023
Contributor
m90
left a comment
m90
left a comment
There was a problem hiding this comment.
LGTM 🦖
Do you still want to add the CHANGELOG entry to this PR so we can ship it when merged?
…nt as notifcation type string
deer-wmde
force-pushed
the
empty_wiki_noti
branch
from
68f6c9b to
44fb3e4
Compare
tarrow
approved these changes
Nov 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://phabricator.wikimedia.org/T344689