Add number of triples count to the wiki daily metric table#919
Conversation
| if ($oldRecord->pages === $todayPageCount) { | ||
| \Log::info("Page count unchanged for WikiMetrics ID {$wiki->id}, no new record added."); | ||
| return; | ||
| \Log::info("Page count unchanged for Wiki ID {$wiki->id}, no new record added."); |
There was a problem hiding this comment.
oof, logic gets complicated here I think again but in this case a new record could still be added if the number of triples changes right?
That means this Log is a bit confusing
I wonder if we now want to pull out all this logic into it's own method(s) to make it easier for humans to parse (and ensure we get the messages we send to users right)?
| return; | ||
| \Log::info("Page count unchanged for Wiki ID {$wiki->id}, no new record added."); | ||
| if ($oldRecord->number_of_triples === $tripleCount) { | ||
| \Log::info("Number of tripples unchanged for Wiki ID {$wiki->id}, no new record added."); |
There was a problem hiding this comment.
| \Log::info("Number of tripples unchanged for Wiki ID {$wiki->id}, no new record added."); | |
| \Log::info("Number of triples unchanged for Wiki ID {$wiki->id}, no new record added."); |
|
Explodes for me locally when testing due to the TLS cert issues there. At the moment I would think the best thing to do would be to import the certificates like we do for the tools (see: wbstack/quickstatements@fe7ecd9) |
rosalieper
force-pushed
the
T391386
branch
2 times, most recently
from
36eb599 to
6c7b569
Compare
| use App\WikiDailyMetrics; | ||
| use Illuminate\Support\Arr; | ||
| use Illuminate\Support\Facades\Http; | ||
| use Illuminate\Support\Facades\Log; |
There was a problem hiding this comment.
This feels nicer to me than \Log in line. Thanks!
* Add number of triples count to the wiki daily metric table * use the queryservice namespace entry point to count the triples * fix tests
2 participants
No description provided.