WikiDailyMetrics: add comparison method#923
Merged
Conversation
Contributor
|
a really nice change. I like the idea of a comparing method. |
tarrow
approved these changes
Apr 25, 2025
deer-wmde
added a commit
that referenced
this pull request
Dec 15, 2025
* add areMetricsEqual method * use areMetricsEqual method * add WikiDailyMetricsTest * fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://phabricator.wikimedia.org/T383427
https://phabricator.wikimedia.org/T391386
In order to more easily compare wiki metric objects we added a comparison method, which will get extended with further metrics properties