-
Notifications
You must be signed in to change notification settings - Fork 3
[PoC] Route to correct MW version #987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| <?php | ||
|
|
||
| namespace App\Services; | ||
|
|
||
| use App\Wiki; | ||
|
|
||
| class MediaWikiHostResolver | ||
| { | ||
| // TODO: Move this mapping to a config file that doesn't require updating this code when doing a MW update? | ||
| /** @var array<string, string> Map of DB version strings to MediaWiki backend version strings */ | ||
| private const DB_VERSION_TO_MW_VERSION = [ | ||
| 'mw1.39-wbs1' => '139-app', | ||
| 'mw1.43-wbs1' => '143-app' | ||
| ]; | ||
|
|
||
| // This service could have other methods in future, e.g. getBackendHostForWiki() | ||
| // public function getBackendHostForWiki(Wiki $wiki): string { | ||
| // return $this->getBackendHostForDomain($wiki->domain); | ||
| // } | ||
|
|
||
| public function getBackendHostForDomain(string $domain): string | ||
| { | ||
| // TODO: should 'backend.default.svc.cluster.local' be an env var e.g. PLATFORM_MW_BACKEND_HOST_SUFFIX? | ||
| return sprintf('mediawiki-%s-backend.default.svc.cluster.local', $this->getMwVersionForDomain($domain)); | ||
| } | ||
|
|
||
| public function getMwVersionForDomain(string $domain): string | ||
| { | ||
| $dbVersion = Wiki::where('domain', $domain) | ||
| ->whereNull('deleted_at') | ||
| ->leftJoin('wiki_dbs', 'wiki_id', '=', 'wikis.id') | ||
| ->pluck('version') | ||
| ->first(); | ||
|
|
||
| return self::DB_VERSION_TO_MW_VERSION[$dbVersion]; | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unclear about the introduction of thisServicenamespace and location, this could be confused with the Laravel concept of Service Providers https://laravel.com/docs/10.x/providersI thinkApp\Helperwould be more appropriate https://github.com/wbstack/api/tree/main/app/HelperI got confused, Service Container is the pattern used here https://laravel.com/docs/10.x/container