UI v0.3.0: switch to ingress API version to GA v1 from v1beta1#104
Merged
rosalieper merged 2 commits intomainfrom Nov 2, 2022
Merged
UI v0.3.0: switch to ingress API version to GA v1 from v1beta1#104rosalieper merged 2 commits intomainfrom
rosalieper merged 2 commits intomainfrom
Conversation
deer-wmde
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://phabricator.wikimedia.org/T311205
ui chart v0.2.19 uses ingress GA API v1 (instead of v1beta1)
some reconfiguration was neccessary:
serviceNameandservicePortwere merged into aservicemappathType: Prefixwas added. It seems this wasn't specified earlier which probably falled back toImplementationSpecific, but this is disencouraged. It looks like it doesn't really matter if we usePrefixorExact, but the former seems more flexible so I chose that.Testable on local cluster