cloud-clusterissuers v0.3.1: fix conditional blocks#194
Merged
Conversation
tarrow
reviewed
May 26, 2025
Contributor
tarrow
left a comment
There was a problem hiding this comment.
Do you think we should keep the Let's Encrypt staging environment present in our production environment?
This was referenced May 26, 2025
Contributor
|
@deer-wmde wrote on mattermost
|
tarrow
approved these changes
May 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In v0.3.0 #187
we added conditional statements for "staging & production" cluster issuers.
What we thought those meant: the cluster issuers for our staging and production environments
What it turned out to be: the Let's Encrypt staging and production environments: https://letsencrypt.org/docs/staging-environment/
So with this version those two get used again for both environments, but not on local.