Skip to content

cloud-clusterissuers v0.3.1: fix conditional blocks#194

Merged
deer-wmde merged 1 commit into
mainfrom
de/cloud-clusterisssuers-0.3.1
May 26, 2025
Merged

cloud-clusterissuers v0.3.1: fix conditional blocks#194
deer-wmde merged 1 commit into
mainfrom
de/cloud-clusterisssuers-0.3.1

Conversation

@deer-wmde
Copy link
Copy Markdown
Contributor

In v0.3.0 #187
we added conditional statements for "staging & production" cluster issuers.

What we thought those meant: the cluster issuers for our staging and production environments
What it turned out to be: the Let's Encrypt staging and production environments: https://letsencrypt.org/docs/staging-environment/

So with this version those two get used again for both environments, but not on local.

Copy link
Copy Markdown
Contributor

@tarrow tarrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we should keep the Let's Encrypt staging environment present in our production environment?

@tarrow
Copy link
Copy Markdown
Contributor

tarrow commented May 26, 2025

@deer-wmde wrote on mattermost

I mean hopefully we won't ever need to change anything there anyway but again, if we do, then we have a way to test retrieving a cert successfully without having to mess with the one that is actually used

@deer-wmde deer-wmde added this pull request to the merge queue May 26, 2025
Merged via the queue into main with commit 491477e May 26, 2025
2 checks passed
@deer-wmde deer-wmde deleted the de/cloud-clusterisssuers-0.3.1 branch May 26, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants