Skip to content

Remove KELOD banner code and DismissableSiteNotice extension#436

Merged
outdooracorn merged 1 commit into
mainfrom
removeBanner
Jun 23, 2025
Merged

Remove KELOD banner code and DismissableSiteNotice extension#436
outdooracorn merged 1 commit into
mainfrom
removeBanner

Conversation

@tarrow
Copy link
Copy Markdown
Contributor

@tarrow tarrow commented Mar 25, 2024

This code is already inactive since the deadline passed. Let's clean it up now

Copy link
Copy Markdown
Contributor

@m90 m90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we should leave some placeholder version of this in-place so we could reuse it even easier than digging in the git history?

In case we do want to remove it entirely, we probably should also drop the extension itself.

Comment thread dist-persist/wbstack/src/Settings/LocalSettings.php
@deer-wmde
Copy link
Copy Markdown
Contributor

Thanks for making this PR. I think Frederik raised good questions and I guess I lean towards removing the extension again, because if I remember correctly, for future use we wanted to solve this differently. But it's hard to say, my crystal ball is currently out of order 🔮

I could also live with only this conf removed

@m90
Copy link
Copy Markdown
Contributor

m90 commented Jul 22, 2024

Do we still want to do this?

@tarrow
Copy link
Copy Markdown
Contributor Author

tarrow commented Jul 23, 2024

both good questions I only bother to reply to after 4 months; I'd suggest we rip out the config and then also remove the extension.

I think while there may be a little digging involved I'd hope that next time we have a banner ticket come in that at a minimum someone searches phabricator for "banner" and "wikibase.cloud" which ought to breadcrumb them into the correct place

@outdooracorn outdooracorn changed the title Remove KELOD Banner code Remove KELOD banner code and DismissableSiteNotice extension Jun 12, 2025
@tarrow
Copy link
Copy Markdown
Contributor Author

tarrow commented Jun 23, 2025

I approve!

This code is inactive since the deadline passed.
Let's remove it and the DismissableSiteNotice extension.
@outdooracorn outdooracorn merged commit b891982 into main Jun 23, 2025
9 checks passed
@outdooracorn outdooracorn deleted the removeBanner branch June 23, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants