Skip to content

Add patchUrl to Echo extension to fix SQLBagOStuff duplicate warnings#500

Merged
dati18 merged 1 commit intomainfrom
fix-duplicate-warning
Dec 9, 2025
Merged

Add patchUrl to Echo extension to fix SQLBagOStuff duplicate warnings#500
dati18 merged 1 commit intomainfrom
fix-duplicate-warning

Conversation

@dati18
Copy link
Contributor

@dati18 dati18 commented Dec 9, 2025

Bug: T412080

@tarrow
Copy link
Contributor

tarrow commented Dec 9, 2025

Are all these composer changes actually supposed to be there?

@outdooracorn
Copy link
Member

outdooracorn commented Dec 9, 2025

Are all these composer changes actually supposed to be there?

From my understanding of

Assuming neither `dist-persist` directory or `pacman.yaml` have changed then running this script should almost be a no-op. The only files we expect to change are composer autoload files and composer's own vendor folder.
those changes are expected. Leaving them out for this patch probably wouldn't be an issue. But if the fix had involved a new PHP file, then we would require the updated autoload files. Seems safest to include them in the PR, but maybe I'm missing something?

@tarrow
Copy link
Contributor

tarrow commented Dec 9, 2025

sure, for now lets include them but maybe we can also figure out a way not to see the no-op reordering

Copy link
Member

@outdooracorn outdooracorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@dati18 dati18 merged commit 6984172 into main Dec 9, 2025
9 checks passed
@dati18 dati18 deleted the fix-duplicate-warning branch December 9, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants