addshore wmde.5 update #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
addshore
commented
Feb 10, 2022
addshore
commented
- Localisation updates from https://translatewiki.net.
- Localisation updates from https://translatewiki.net.
- Localisation updates from https://translatewiki.net.
- npm audit fix
- selenium: Upgrade WebdriverIO to v7
- Localisation updates from https://translatewiki.net.
- Update java example to use rdf4j
- Use the correct build command
- Make embed and non-embed tracking namespace have equal footing
- Localisation updates from https://translatewiki.net.
- Localisation updates from https://translatewiki.net.
- Localisation updates from https://translatewiki.net.
- Localisation updates from https://translatewiki.net.
- Localisation updates from https://translatewiki.net.
- Update dist/ and npm version number
- Localisation updates from https://translatewiki.net.
- Update cldrpluralruleparser package
- Change path of QueryBuilder for metric gathering to production
- Pin cldrpluralruleparser to 1.3.2
- Add a banner for WDQS User Research Survey 2021
- Localisation updates from https://translatewiki.net.
- Add ‘Query Builder’ Button + tooltip
- Localisation updates from https://translatewiki.net.
- Localisation updates from https://translatewiki.net.
- Add support for passing the language to the query builder link
- Localisation updates from https://translatewiki.net.
- Localisation updates from https://translatewiki.net.
- Localisation updates from https://translatewiki.net.
- Localisation updates from https://translatewiki.net.
- Add query builder banner
- Add missing banner JS to embed.html
- Update embed_spec assertion
- Add Github Actions dependabot workflow
- Localisation updates from https://translatewiki.net.
- Bump qunit from 2.14.0 to 2.17.2
- Bump grunt-cli from 1.3.2 to 1.4.3
- Bump jstree from 3.3.11 to 3.3.12
- Bump @wdio/local-runner from 7.4.6 to 7.13.1
- Bump leaflet.markercluster from 1.4.1 to 1.5.1
- Bump sinon from 4.5.0 to 11.1.2
- Bump leaflet.locatecontrol from 0.62.0 to 0.74.0
- Bump eslint-plugin-promise from 4.3.1 to 5.1.0
- Bump webdriverio from 7.4.6 to 7.13.1
- Bump jquery-resizable-dom from 0.20.0 to 0.35.0
- Bump grunt-contrib-clean from 1.1.0 to 2.0.0
- Bump @wdio/cli from 7.4.6 to 7.13.1
- Bump http-server from 0.12.3 to 13.0.2
- Bump @wdio/spec-reporter from 7.4.3 to 7.13.0
- Bump eslint-plugin-compat from 3.9.0 to 3.13.0
- Bump grunt-contrib-less from 2.0.0 to 3.0.0
- Bump grunt-contrib-htmlmin from 2.4.0 to 3.1.0
- Bump codemirror from 5.61.0 to 5.63.0
- Localisation updates from https://translatewiki.net.
- Bump @wdio/local-runner from 7.13.1 to 7.13.2
- Bump jquery from 3.5.1 to 3.6.0
- Bump grunt-banana-checker from 0.6.0 to 0.9.0
- Add requireKeyPrefix to banana-checker config
- Bump codemirror from 5.63.0 to 5.63.1
- Localisation updates from https://translatewiki.net.
- Localisation updates from https://translatewiki.net.
- Bump grunt-contrib-jshint from 1.1.0 to 3.1.1
- Bump grunt-contrib-cssmin from 2.2.1 to 4.0.0
- Bump grunt-stylelint from 0.15.0 to 0.16.0
- Bump karma-qunit from 1.2.1 to 3.0.0
- Bump bootstrap-table from 1.18.2 to 1.18.3
- Bump @wdio/cli from 7.13.1 to 7.14.1
- Bump @wdio/local-runner from 7.13.2 to 7.14.1
- Bump gijgo from 1.9.6 to 1.9.13
- Bump @wdio/mocha-framework from 7.4.6 to 7.14.1
- Bump leaflet-zoombox from 0.5.1 to 0.5.2
- Bump mathjax from 3.1.2 to 3.2.0
- Bump stylelint from 13.10.0 to 13.13.1
- Localisation updates from https://translatewiki.net.
- Bump @wdio/spec-reporter from 7.13.0 to 7.14.1
- Bump @wdio/dot-reporter from 6.11.0 to 7.14.1
- Bump load-grunt-tasks from 3.5.2 to 5.1.0
- Bump grunt-shell from 2.1.0 to 3.0.1
- Bump grunt-contrib-uglify from 3.4.0 to 5.0.1
- Bump grunt-jsonlint from 1.1.0 to 2.1.3
- Bump grunt-contrib-qunit from 3.1.0 to 5.1.1
- Bump webdriverio from 7.13.1 to 7.14.1
- Bump grunt from 1.3.0 to 1.4.1
- Bump grunt-contrib-concat from 1.0.1 to 2.0.0
- Bump stylelint-config-wikimedia from 0.10.3 to 0.11.1
- Localisation updates from https://translatewiki.net.
- npm audit fix
- Bump codemirror from 5.63.1 to 5.63.3
- Bump leaflet.markercluster from 1.5.1 to 1.5.3
- Bump grunt-eslint from 23.0.0 to 24.0.0
- Localisation updates from https://translatewiki.net.
- Bump http-server from 13.0.2 to 14.0.0
- Bump eslint-plugin-promise from 5.1.0 to 5.1.1
- Localisation updates from https://translatewiki.net.
- Bump @wdio/cli from 7.14.1 to 7.16.1
- Bump webdriverio from 7.14.1 to 7.16.1
- Bump @wdio/mocha-framework from 7.14.1 to 7.16.1
- Bump @wdio/local-runner from 7.14.1 to 7.16.1
- Bump @wdio/spec-reporter from 7.14.1 to 7.16.1
- Bump @wdio/dot-reporter from 7.14.1 to 7.16.1
- Bump @wdio/local-runner from 7.16.1 to 7.16.2
- Bump webdriverio from 7.16.1 to 7.16.2
- Bump @wdio/cli from 7.16.1 to 7.16.2
- Localisation updates from https://translatewiki.net.
- Bump webdriverio from 7.16.2 to 7.16.3
- Bump @wdio/cli from 7.16.2 to 7.16.3
- Bump @wdio/local-runner from 7.16.2 to 7.16.3
- Bump @wdio/mocha-framework from 7.16.1 to 7.16.3
- Bump @wdio/dot-reporter from 7.16.1 to 7.16.3
- Bump @wdio/spec-reporter from 7.16.1 to 7.16.3
- Localisation updates from https://translatewiki.net.
- Localisation updates from https://translatewiki.net.
- Bump leaflet.locatecontrol from 0.74.0 to 0.74.1
- Bump webdriverio from 7.16.3 to 7.16.4
- Bump @wdio/cli from 7.16.3 to 7.16.4
- Bump @wdio/spec-reporter from 7.16.3 to 7.16.4
- Localisation updates from https://translatewiki.net.
- Bump sinon from 11.1.2 to 12.0.1
- Bump @wdio/dot-reporter from 7.16.3 to 7.16.4
- Bump @wdio/mocha-framework from 7.16.3 to 7.16.4
- Bump @wdio/local-runner from 7.16.3 to 7.16.4
- Bump bootstrap-table from 1.18.3 to 1.19.0
- Bump webdriverio from 7.16.4 to 7.16.5
- Update title when loading query
- Bump @wdio/cli from 7.16.4 to 7.16.5
- Bump @wdio/local-runner from 7.16.4 to 7.16.5
- Bump webdriverio from 7.16.5 to 7.16.6
- Bump @wdio/cli from 7.16.5 to 7.16.6
- Bump @wdio/dot-reporter from 7.16.4 to 7.16.6
- Bump @wdio/local-runner from 7.16.5 to 7.16.6
- Bump @wdio/mocha-framework from 7.16.4 to 7.16.6
- Bump bootstrap-table from 1.19.0 to 1.19.1
- Empty commit to de-confuse deployment build
- Bump webdriverio from 7.16.6 to 7.16.7
- Bump @wdio/cli from 7.16.6 to 7.16.7
- Bump @wdio/local-runner from 7.16.6 to 7.16.7
- Localisation updates from https://translatewiki.net.
- Localisation updates from https://translatewiki.net.
- Bump codemirror from 5.63.3 to 5.64.0
- Bump webdriverio from 7.16.7 to 7.16.9
- Bump @wdio/spec-reporter from 7.16.4 to 7.16.9
- Bump @wdio/cli from 7.16.7 to 7.16.9
- Bump @wdio/local-runner from 7.16.7 to 7.16.9
- Localisation updates from https://translatewiki.net.
- Bump webdriverio from 7.16.9 to 7.16.10
- Localisation updates from https://translatewiki.net.
- Bump @wdio/cli from 7.16.9 to 7.16.10
- Bump @wdio/local-runner from 7.16.9 to 7.16.10
- Bump webdriverio from 7.16.10 to 7.16.11
- Bump @wdio/dot-reporter from 7.16.6 to 7.16.11
- Bump @wdio/cli from 7.16.10 to 7.16.11
- Bump @wdio/local-runner from 7.16.10 to 7.16.11
- Bump @wdio/mocha-framework from 7.16.6 to 7.16.11
- Bump @wdio/spec-reporter from 7.16.9 to 7.16.11
- Localisation updates from https://translatewiki.net.
- Bump underscore from 1.13.1 to 1.13.2
- Localisation updates from https://translatewiki.net.
- Localisation updates from https://translatewiki.net.
- Localisation updates from https://translatewiki.net.
- Localisation updates from https://translatewiki.net.
- Localisation updates from https://translatewiki.net.
- Bump webdriverio from 7.16.11 to 7.16.13
- Localisation updates from https://translatewiki.net.
- Localisation updates from https://translatewiki.net.
- Bump @wdio/cli from 7.16.11 to 7.16.13
- Bump @wdio/local-runner from 7.16.11 to 7.16.13
- Bump @wdio/dot-reporter from 7.16.11 to 7.16.13
- Bump @wdio/spec-reporter from 7.16.11 to 7.16.13
- Bump @wdio/mocha-framework from 7.16.11 to 7.16.13
- Bump codemirror from 5.64.0 to 5.65.0
- Bump http-server from 14.0.0 to 14.1.0
- Localisation updates from https://translatewiki.net.
- Bump codemirror from 5.65.0 to 5.65.1
- Bump webdriverio from 7.16.13 to 7.16.14
- Bump @wdio/cli from 7.16.13 to 7.16.14
- Bump @wdio/dot-reporter from 7.16.13 to 7.16.14
- Bump @wdio/local-runner from 7.16.13 to 7.16.14
- Bump @wdio/mocha-framework from 7.16.13 to 7.16.14
- Bump @wdio/spec-reporter from 7.16.13 to 7.16.14
- Bump eslint-plugin-promise from 5.1.1 to 6.0.0
- Bump sinon from 12.0.1 to 13.0.0
- Bump eslint-plugin-compat from 3.13.0 to 4.0.1
- Bump eslint-plugin-compat from 4.0.1 to 4.0.2
- Bump sinon from 13.0.0 to 13.0.1
- Localisation updates from https://translatewiki.net.
- Localisation updates from https://translatewiki.net.
- Don’t create links with javascript: hrefs
- Construct query helper search results better
- Construct result browser explore button better
Change-Id: I6da9e5814b071849d282278ec9ce706e40000d4f
Change-Id: Id2700e6a6402965525ff4b6b90b6b264c6c82161
Change-Id: Ib3bfabf51ca878825cd1a2ebf4516ce003ac5609
Change-Id: I07dacc606ffa61db3e97df4d1ef7d90877fabebc
Update npm packages: @wdio/* and webdriverio. Bug: T274579 Change-Id: I57c8b8b4471d8dd2ee7183deb6403275b9817801
Change-Id: Id5b296139c66a8e2b342ff560d145bfb8d2c6605
To try this out easiest would be running https://github.com/toban/rdf4j-wikidata-sparql-example I've confirmed that the user-agent gets set correctly. Bug: T259900 Change-Id: Ie6d24be640aa318507237de05ae28d115149e23f
Bug: T286479 Change-Id: Id64ff253afbbb402e71e470290421bb353f4c4c3
Currently the namespace for non-embed is: wikibase.queryService.ui. and for embedded requests is: wikibase.queryService.ui.embed. This makes building graphs that need to combine data of both a nightmare. Bug: T272128 Change-Id: I0ef9f613e833fd8d8be3cb1e7f284a02dee2f195
Change-Id: I036d2b03d88e58e146f73714394c52264f33b2b8
Change-Id: I8f96ed5d8e5c177560f14b6eff841e1a0966ccc1
Change-Id: If614f658837cdb88d6c462c834c25c973dc52100
Change-Id: I306499320925df1c7d153b2150f441aa8038e1d8
Change-Id: Ib7e34b55fe33885799d18d72b17c203d0cee50b2
The previous dist/ files were almost five years old (last touched in change If3409146d7, commit 54372c8, December 2016). I don’t know how they were created at the time, but I’ve now found a manual process to recreate files that can at least be used to power a SPARQL editor outside of the query service UI. I think this is still an improvement worth releasing, though in the long run we should obviously be able to build the package properly. To produce the CSS and JS files, I reorganized the index.html so that all the non-node_modules/ files ended up in one JS or CSS bundle, respectively. This meant moving the JS files in vendor/ (i.e. code that isn’t ours, but that we commit to Git instead of getting it from npm, for Reasons™) from the vendor.min.js block into the wdqs.min.js block (note: at the beginning of the block, not the end!), and splitting a vendor.min.css block out of the style.min.css block (with the vendor/ CSS file still going into style.min.css). I also removed the files from index.html that shouldn’t be in the npm package at all: config.js and init.js. (The resulting index.html diff can be found at P16980 [1].) I then ran `npm run build` and copied the resulting build/js/wdqs.min.*.js and build/css/style.min.*.css into dist/. To actually use the package, you effectively have to copy most of the node_modules/ stylesheets and scripts from our index.html into your custom one, which isn’t great, but would require a much larger effort to fix (T288466). But once you have that, something like this works: <script src="node_modules/wikidata-query-gui/dist/js/wdqs.min.js"></script> <link rel="stylesheet" href="node_modules/wikidata-query-gui/dist/css/style.min.css"> <textarea id="sparql"></textarea> <script> var editor = new wikibase.queryService.ui.editor.Editor(); editor.fromTextArea(document.getElementById('sparql')); </script> and then you get a working editor with syntax highlighting and hovercards and other amenities. The README has some more usage examples (e.g. using the SPARQL API), but I haven’t tested those. I think being able to get a working editor is already useful and worthy of a 0.2.0 release. [1]: https://phabricator.wikimedia.org/P16980 Bug: T267836 Change-Id: I4de6202b45f6563b7ba291180a499220f4cdafcd
Change-Id: Ib0ddb402ddde1217a1e4dbe5c8ea1ee2a4c4516c
Since version 1.4.0 of the package, src/CLDRPluralRuleParser.js is an ES6 module with import/export syntax, so trying to load it directly as a <script> no longer works. Get a browser build from dist/ instead. Change-Id: I75702667f73834455bc5dc84e3aa7c756d821ffb
It's deployed to production Bug: T266703 Change-Id: I57e44694f2e9774f3c813f4b6e6199a0ad1905a2
This effectively reverts change I75702667f7 (commit f604d01) and pins cldrpluralruleparser to the version we used before, without allowing a “non-breaking” upgrade to 1.4.0 which is actually very much breaking for us (they started using ES6 syntax like let/const). (Also, I had actually forgotten to edit embed.html in that change, so that wouldn’t have worked anyways. Oops.) Change-Id: I22fbb4d00d16f0e3d6369445aadc4a1cec70b319
Built using Ic054e0f9a232ba43 Bug: T288753 Change-Id: I17964f1aed9d7e97c06daa7891f6f87769c8e34f
Change-Id: I09b4a4923f4145a02078a1072f5e2b1e03ef612c
This is splitting out Ic054e0f9a232b and also making the query-builder URL come from the config (From I59d985df17d6) instead of hard-coding it. Bug: T276210 Change-Id: I50e3fba97134ab55acac496a153334867074770d Co-authored-by: Adamham <mail@adamham.dev>
Change-Id: I4937a6c6f265da27dee29ae36b0ed6802ccc9d1e
Change-Id: I2f1c0f58b0e2b3546b20156ca1edc94d8abaf038
Bug: T276210 Change-Id: I480d242b1eab0677826127b9ef7cce40ffcd0a3d
Change-Id: I92f4c1455d97f96dd11331691f54d8a875d355af
Bumps [@wdio/dot-reporter](https://github.com/webdriverio/webdriverio) from 7.16.11 to 7.16.13. - [Release notes](https://github.com/webdriverio/webdriverio/releases) - [Changelog](https://github.com/webdriverio/webdriverio/blob/main/CHANGELOG.md) - [Commits](webdriverio/webdriverio@v7.16.11...v7.16.13) --- updated-dependencies: - dependency-name: "@wdio/dot-reporter" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Pull Request: wikimedia/wikidata-query-gui#139 Change-Id: I7853720c25b31a6bf4bc9f2c0e73fc54e51af8c4
Bumps [@wdio/spec-reporter](https://github.com/webdriverio/webdriverio) from 7.16.11 to 7.16.13. - [Release notes](https://github.com/webdriverio/webdriverio/releases) - [Changelog](https://github.com/webdriverio/webdriverio/blob/main/CHANGELOG.md) - [Commits](webdriverio/webdriverio@v7.16.11...v7.16.13) --- updated-dependencies: - dependency-name: "@wdio/spec-reporter" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Pull Request: wikimedia/wikidata-query-gui#140 Change-Id: I75e1cd084b3cb060f7b9c75b0400953f59c2028c
Bumps [@wdio/mocha-framework](https://github.com/webdriverio/webdriverio) from 7.16.11 to 7.16.13. - [Release notes](https://github.com/webdriverio/webdriverio/releases) - [Changelog](https://github.com/webdriverio/webdriverio/blob/main/CHANGELOG.md) - [Commits](webdriverio/webdriverio@v7.16.11...v7.16.13) --- updated-dependencies: - dependency-name: "@wdio/mocha-framework" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Pull Request: wikimedia/wikidata-query-gui#142 Change-Id: Iff8f46c5d28941ae59b0bc1b9f745116a700acee
Bumps [codemirror](https://github.com/codemirror/CodeMirror) from 5.64.0 to 5.65.0. - [Release notes](https://github.com/codemirror/CodeMirror/releases) - [Changelog](https://github.com/codemirror/CodeMirror/blob/master/CHANGELOG.md) - [Commits](codemirror/codemirror5@5.64.0...5.65.0) --- updated-dependencies: - dependency-name: codemirror dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Pull Request: wikimedia/wikidata-query-gui#141 Change-Id: Idb2d929585b56ab38d15c7444a598de995aec6c2
Bumps [http-server](https://github.com/http-party/http-server) from 14.0.0 to 14.1.0. - [Release notes](https://github.com/http-party/http-server/releases) - [Commits](http-party/http-server@v14.0.0...v14.1.0) --- updated-dependencies: - dependency-name: http-server dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Pull Request: wikimedia/wikidata-query-gui#138 Change-Id: Ie564f6a07ef499b0a41331fc29b192f76161e491
Change-Id: Ieca197b9593704c28c9cc4b3b1fbc11009c6fa05
Bumps [codemirror](https://github.com/codemirror/CodeMirror) from 5.65.0 to 5.65.1. - [Release notes](https://github.com/codemirror/CodeMirror/releases) - [Changelog](https://github.com/codemirror/CodeMirror/blob/master/CHANGELOG.md) - [Commits](codemirror/codemirror5@5.65.0...5.65.1) --- updated-dependencies: - dependency-name: codemirror dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Pull Request: wikimedia/wikidata-query-gui#143 Change-Id: I144557274f5e4dc3b4e11f6743e69f7ef265f632
Bumps [webdriverio](https://github.com/webdriverio/webdriverio) from 7.16.13 to 7.16.14. - [Release notes](https://github.com/webdriverio/webdriverio/releases) - [Changelog](https://github.com/webdriverio/webdriverio/blob/main/CHANGELOG.md) - [Commits](webdriverio/webdriverio@v7.16.13...v7.16.14) --- updated-dependencies: - dependency-name: webdriverio dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Pull Request: wikimedia/wikidata-query-gui#147 Change-Id: Ic1567239119afd6f7a6aa1c0960758e72b5703e5
Bumps [@wdio/cli](https://github.com/webdriverio/webdriverio) from 7.16.13 to 7.16.14. - [Release notes](https://github.com/webdriverio/webdriverio/releases) - [Changelog](https://github.com/webdriverio/webdriverio/blob/main/CHANGELOG.md) - [Commits](webdriverio/webdriverio@v7.16.13...v7.16.14) --- updated-dependencies: - dependency-name: "@wdio/cli" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Pull Request: wikimedia/wikidata-query-gui#149 Change-Id: I8eb0e5322e1e5479d681efb2d9dcfbf69b1f6a46
Bumps [@wdio/dot-reporter](https://github.com/webdriverio/webdriverio) from 7.16.13 to 7.16.14. - [Release notes](https://github.com/webdriverio/webdriverio/releases) - [Changelog](https://github.com/webdriverio/webdriverio/blob/main/CHANGELOG.md) - [Commits](webdriverio/webdriverio@v7.16.13...v7.16.14) --- updated-dependencies: - dependency-name: "@wdio/dot-reporter" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Pull Request: wikimedia/wikidata-query-gui#151 Change-Id: Iddc3ed7a5d8275009645c9ee13e4684616115049
Bumps [@wdio/local-runner](https://github.com/webdriverio/webdriverio) from 7.16.13 to 7.16.14. - [Release notes](https://github.com/webdriverio/webdriverio/releases) - [Changelog](https://github.com/webdriverio/webdriverio/blob/main/CHANGELOG.md) - [Commits](webdriverio/webdriverio@v7.16.13...v7.16.14) --- updated-dependencies: - dependency-name: "@wdio/local-runner" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Pull Request: wikimedia/wikidata-query-gui#148 Change-Id: I287af289d43d3038714aafc56f5128efdc78be0b
Bumps [@wdio/mocha-framework](https://github.com/webdriverio/webdriverio) from 7.16.13 to 7.16.14. - [Release notes](https://github.com/webdriverio/webdriverio/releases) - [Changelog](https://github.com/webdriverio/webdriverio/blob/main/CHANGELOG.md) - [Commits](webdriverio/webdriverio@v7.16.13...v7.16.14) --- updated-dependencies: - dependency-name: "@wdio/mocha-framework" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Pull Request: wikimedia/wikidata-query-gui#152 Change-Id: Ie831613a0aaa47e5f13450fc4637a80c71ad042b
Bumps [@wdio/spec-reporter](https://github.com/webdriverio/webdriverio) from 7.16.13 to 7.16.14. - [Release notes](https://github.com/webdriverio/webdriverio/releases) - [Changelog](https://github.com/webdriverio/webdriverio/blob/main/CHANGELOG.md) - [Commits](webdriverio/webdriverio@v7.16.13...v7.16.14) --- updated-dependencies: - dependency-name: "@wdio/spec-reporter" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Pull Request: wikimedia/wikidata-query-gui#150 Change-Id: I7b107083f0ba3a467fde270cca269900f0ceee38
Bumps [eslint-plugin-promise](https://github.com/xjamundx/eslint-plugin-promise) from 5.1.1 to 6.0.0. - [Release notes](https://github.com/xjamundx/eslint-plugin-promise/releases) - [Changelog](https://github.com/xjamundx/eslint-plugin-promise/blob/development/CHANGELOG.md) - [Commits](https://github.com/xjamundx/eslint-plugin-promise/commits) --- updated-dependencies: - dependency-name: eslint-plugin-promise dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Pull Request: wikimedia/wikidata-query-gui#132 Change-Id: I615cf6f4184b3eac0a8edb0d59be0d844cfacb35
Bumps [sinon](https://github.com/sinonjs/sinon) from 12.0.1 to 13.0.0. - [Release notes](https://github.com/sinonjs/sinon/releases) - [Changelog](https://github.com/sinonjs/sinon/blob/master/docs/changelog.md) - [Commits](sinonjs/sinon@v12.0.1...v13.0.0) --- updated-dependencies: - dependency-name: sinon dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Pull Request: wikimedia/wikidata-query-gui#153 Change-Id: Ib9a4fb3c4f941599123d91a20b868243755a7e45
Bumps [eslint-plugin-compat](https://github.com/amilajack/eslint-plugin-compat) from 3.13.0 to 4.0.1. - [Release notes](https://github.com/amilajack/eslint-plugin-compat/releases) - [Changelog](https://github.com/amilajack/eslint-plugin-compat/blob/main/CHANGELOG.md) - [Commits](amilajack/eslint-plugin-compat@v3.13.0...v4.0.1) --- updated-dependencies: - dependency-name: eslint-plugin-compat dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Pull Request: wikimedia/wikidata-query-gui#133 Change-Id: I3b7311f07aa28d43b808f70b9a3009316746f010
Bumps [eslint-plugin-compat](https://github.com/amilajack/eslint-plugin-compat) from 4.0.1 to 4.0.2. - [Release notes](https://github.com/amilajack/eslint-plugin-compat/releases) - [Changelog](https://github.com/amilajack/eslint-plugin-compat/blob/main/CHANGELOG.md) - [Commits](amilajack/eslint-plugin-compat@v4.0.1...v4.0.2) --- updated-dependencies: - dependency-name: eslint-plugin-compat dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Pull Request: wikimedia/wikidata-query-gui#154 Change-Id: Id8f54c74cb7885b42cf9129b32d3b9e70f8142f6
Bumps [sinon](https://github.com/sinonjs/sinon) from 13.0.0 to 13.0.1. - [Release notes](https://github.com/sinonjs/sinon/releases) - [Changelog](https://github.com/sinonjs/sinon/blob/master/docs/changelog.md) - [Commits](sinonjs/sinon@v13.0.0...v13.0.1) --- updated-dependencies: - dependency-name: sinon dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Pull Request: wikimedia/wikidata-query-gui#155 Change-Id: I0b65abbc98425e5c70d563d7a9e6b1a03d737e9a
Change-Id: Ia1f818322a4914f4c010ae9cdc27cd3f59000ed1
Change-Id: Iecbbc6e1ce5222b752c285f79df301d4a8e9f335
I think we can be permissive with other protocols (i.e. not just HTTP and HTTPS – query service users are very inventive), but there’s no reason to allow JavaScript links to be created. Bug: T297686 Change-Id: I31c15a6e8ac79a3a6e3720469aae4718bcf33a68
Use jQuery to create elements with the desired *text* content, instead of directly concatenating strings into HTML. Bug: T298839 Change-Id: I9edc0b76d71748443e98fb33fde4b95b70386552
Use jQuery to create elements with the desired attribute values, instead of directly concatenating strings into HTML. Bug: T298871 Change-Id: I57cf977f86cf19ec64f090e896349205c4d4cc5a
|
Looks good to me; local test with skaffold confirmed that T298871, T298839 seems to be resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.