-
Notifications
You must be signed in to change notification settings - Fork 9
Use more meaningful names for step cards in CreateWikiWizard #1106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
outdooracorn
wants to merge
5
commits into
main
Choose a base branch
from
improve-naming
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
3b61f3a
UI: Refactor Create Wizard Cards in Platform UI and Add Step 4
rosalieper 06278dc
fix linting
rosalieper 2568e2e
Remove step 4 in createWiki.vue
rosalieper 46545cd
Continue refactoring
outdooracorn 0d64eb7
Use more meaningful names for step cards in CreateWikiWizard
outdooracorn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
130 changes: 130 additions & 0 deletions
130
src/components/Cards/TemporalityCreateWikiWizardStep.vue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,130 @@ | ||
| <template> | ||
| <v-card class="elevation-12"> | ||
| <v-toolbar dark color="primary"> | ||
| <v-toolbar-title>{{ title }}</v-toolbar-title> | ||
| </v-toolbar> | ||
|
|
||
| <v-card-text> | ||
| <v-form ref="inputForm" v-on:submit.prevent> | ||
| <h3>How long do you plan to use this Wikibase?</h3> | ||
|
|
||
| <v-radio-group | ||
| v-model="value.temporality" | ||
| :error-messages=error | ||
| :rules="[() => !!value.temporality || 'Please select an option.']" | ||
| > | ||
| <v-radio value="permanent" ref="test"> | ||
| <template v-slot:label> | ||
| I would prefer to keep it on a permanent basis | ||
| </template> | ||
| </v-radio> | ||
| <v-radio value="temporary"> | ||
| <template v-slot:label> | ||
| It is temporary/disposable. I will no longer need it after it served its purpose | ||
| </template> | ||
| </v-radio> | ||
|
|
||
| <v-radio value="other"> | ||
| <template v-slot:label> | ||
| Other: <v-text-field | ||
| dense | ||
| counter="200" | ||
| class="pl-1 mt-n1 mb-n2" | ||
| v-model="value.otherTemporality" | ||
| :rules=" | ||
| [ | ||
| () => value.temporality !== 'other' | ||
| || !! value.otherTemporality | ||
| || 'Please provide a response.', | ||
|
|
||
| () => value.temporality !== 'other' | ||
| || !! (value.otherTemporality && value.otherTemporality.length < 201) | ||
| || 'Text must be 200 characters or less.' | ||
| ]" | ||
| ></v-text-field> | ||
| </template> | ||
| </v-radio> | ||
| <v-radio value="decide_later"> | ||
| <template v-slot:label> | ||
| I will decide later | ||
| </template> | ||
| </v-radio> | ||
| </v-radio-group> | ||
| <h3 class="mt-6">Terms of Use</h3> | ||
| <div class="body-2"> | ||
| Previously accepted | ||
| <v-tooltip top> | ||
| <template v-slot:activator="{ on }"> | ||
| <a | ||
| target="_blank" | ||
| href="/terms-of-use" | ||
| @click.stop | ||
| v-on="on" | ||
| > | ||
| Terms of Use</a> | ||
| </template> | ||
| Opens in new window | ||
| </v-tooltip> still apply. | ||
| </div> | ||
| </v-form> | ||
| </v-card-text> | ||
| <v-card-actions> | ||
| <v-btn | ||
| type="button" | ||
| :disabled="inFlight" | ||
| @click="previousStep" | ||
| > | ||
| < Previous | ||
| </v-btn> | ||
|
|
||
| <v-btn | ||
| type="button" | ||
| color="primary" | ||
| :disabled="inFlight" | ||
| @click="submitWholeForm" | ||
| > | ||
| Create Wiki | ||
| </v-btn> | ||
| </v-card-actions> | ||
| </v-card> | ||
| </template> | ||
|
|
||
| <script> | ||
| export default { | ||
| name: 'TemporalityCreateWikiWizardStep', | ||
| props: { | ||
| title: String, | ||
| inFlight: Boolean, | ||
| value: Object, | ||
| error: Array | ||
| }, | ||
| methods: { | ||
| previousStep () { | ||
| if (this.value.temporality !== 'other') { | ||
| this.value.otherTemporality = undefined | ||
| } | ||
|
|
||
| this.$emit('previous-step') | ||
| }, | ||
| submitWholeForm () { | ||
| if (this.value.temporality !== 'other') { | ||
| this.value.otherTemporality = undefined | ||
| } | ||
|
|
||
| this.$refs.inputForm.validate() | ||
| if (this.$refs.inputForm.validate() === true) { | ||
| this.$emit('submit') | ||
| } | ||
| } | ||
| } | ||
|
|
||
| } | ||
| </script> | ||
|
|
||
| <style lang="css" scoped> | ||
| .v-card__actions { | ||
| flex-wrap: wrap; | ||
| justify-content: flex-end; | ||
| gap: 8px; | ||
| } | ||
| </style> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you think of adding the word "step" to this names, so that we do not have to reference it with
temporality.temporality.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice idea I think I like that too. I think specifically this is looking at R135 below