Open
Conversation
|
Deployment previews on netlify for branch
|
Bug: T422593
outdooracorn
requested changes
Apr 14, 2026
Member
outdooracorn
left a comment
outdooracorn
left a comment
There was a problem hiding this comment.
Managed to do a quick review.
I would comment out all the custom CSS and see how far you can get with Vuetify-native CSS classes. Reach out for collaboration if that is proving difficult. If we have to add custom CSS we should also write a comment explaining why it was necessary.
outdooracorn
requested changes
Apr 15, 2026
Member
outdooracorn
left a comment
outdooracorn
left a comment
There was a problem hiding this comment.
Another quick review with some nitpicks. We are getting there :D
outdooracorn
requested changes
Apr 16, 2026
Member
There was a problem hiding this comment.
Sorry, I wasn't very clear that we should remove all the strong and em elements unless the text is conveying importance or emphasis. Ask yourself, "if I was reading this sentence out loud, would I shout or otherwise emphasizes that part of the sentence?". If not, then the bold and/or italic styling should be done via CSS classes.
I've added some suggestions to provide more examples to go off, but I haven't done them all.
| <h3 class="mb-3 mt-6" id="target-audience">1.1 Target Audience</h3> | ||
| <ul class="mb-4"> | ||
| <li>Primary audience: the <a class="font-weight-bold font-italic" href="#review-committee">Review Committee</a> responsible for reviewing and approving Wikibase Cloud hosting requests for continued use. The policy provides a shared framework for making consistent, transparent decisions grounded in mission alignment, resource realities, and inclusivity goals.</li> | ||
| <li>Secondary audience: <strong>Wikibase Cloud's current and prospective users</strong>, who can use this document to understand the reasoning behind WMDE’s hosting criteria and to self-assess whether their use case is likely to be accepted.</li> |
Member
There was a problem hiding this comment.
Suggested change
| <li>Secondary audience: <strong>Wikibase Cloud's current and prospective users</strong>, who can use this document to understand the reasoning behind WMDE’s hosting criteria and to self-assess whether their use case is likely to be accepted.</li> | |
| <li>Secondary audience: <span class="font-weight-bold">Wikibase Cloud's current and prospective users</span>, who can use this document to understand the reasoning behind WMDE’s hosting criteria and to self-assess whether their use case is likely to be accepted.</li> |
| </ul> | ||
| <h3 id="relationship-to-other-governance-documents">1.2 Relationship to other governance documents</h3> | ||
| <h3 class="mb-3" id="relationship-to-other-governance-documents">1.2 Relationship to other governance documents</h3> | ||
| <p><em>(These relationships matter to ensure hosting criteria remain coherent with other governance documents, prevent contradictory expectations for contributors, and avoid overlap between responsibilities of WMDE, WMF, and individual communities.)</em></p> |
Member
There was a problem hiding this comment.
Suggested change
| <p><em>(These relationships matter to ensure hosting criteria remain coherent with other governance documents, prevent contradictory expectations for contributors, and avoid overlap between responsibilities of WMDE, WMF, and individual communities.)</em></p> | |
| <p class="font-italic">(These relationships matter to ensure hosting criteria remain coherent with other governance documents, prevent contradictory expectations for contributors, and avoid overlap between responsibilities of WMDE, WMF, and individual communities.)</p> |
| <p><em>(These relationships matter to ensure hosting criteria remain coherent with other governance documents, prevent contradictory expectations for contributors, and avoid overlap between responsibilities of WMDE, WMF, and individual communities.)</em></p> | ||
| <ul> | ||
| <ul class="pl-5 mb-3"> | ||
| <li>This policy complements the <strong><a href="/terms-of-use">Wikibase Cloud Terms of Use</a></strong>, which define the legal and compliance conditions for using the platform.</li> |
Member
There was a problem hiding this comment.
Suggested change
| <li>This policy complements the <strong><a href="/terms-of-use">Wikibase Cloud Terms of Use</a></strong>, which define the legal and compliance conditions for using the platform.</li> | |
| <li>This policy complements the <a class="font-weight-bold" href="/terms-of-use">Wikibase Cloud Terms of Use</a>, which define the legal and compliance conditions for using the platform.</li> |
| <h3 class="mb-3" id="relationship-to-other-governance-documents">1.2 Relationship to other governance documents</h3> | ||
| <p><em>(These relationships matter to ensure hosting criteria remain coherent with other governance documents, prevent contradictory expectations for contributors, and avoid overlap between responsibilities of WMDE, WMF, and individual communities.)</em></p> | ||
| <ul> | ||
| <ul class="pl-5 mb-3"> |
Member
There was a problem hiding this comment.
Can we do the same as #1121 (comment) for all these top level ul elements, please?
Suggested change
| <ul class="pl-5 mb-3"> | |
| <ul class="mb-4"> |
| </ul> | ||
| <div> | ||
| <v-alert colored-border type="warning" prominent border="left" elevation="2"> | ||
| <ul class="mb-1"> |
Member
There was a problem hiding this comment.
As this is in an alert and has sufficient margins/padding, I don't think we need to add any more.
Suggested change
| <ul class="mb-1"> | |
| <ul> |
| <v-alert color="info" text > | ||
| <p id="assessing-size-and-load"><strong>Assessment of size and load</strong></p> | ||
| <p>Wikibase Cloud does not operate with fixed numerical limits for dataset size or traffic at this stage. Decisions about size and load will be made empirically, based on observed platform behavior and past incidents. When an instance creates significant strain on the infrastructure, the situation will be investigated, discussed with the instance manager and documented in a public log together with the decision taken.</p> | ||
| <p>If a high-load use case is meaningful, the Review Committee may assess whether technical improvements and the effort to make them are reasonable. If they are, the use case will only produce a <em><a href="#concerning-signals">Concerning Signal</a></em>. Over time, documented cases will inform future decisions, creating a growing body of precedent. In all cases, instance managers will be contacted and involved in finding a reasonable solution before further action is taken.</p> |
Member
There was a problem hiding this comment.
Not something you have introduced, but I notice this is two separate paragraphs on https://www.mediawiki.org/wiki/Wikibase/Wikibase.cloud/Hosting_policy_(pilot_version)#%F0%9F%94%B4_Disqualifying_Conditions_(must_not_be_true)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: T422593