Merged
Conversation
|
Deployment previews on netlify for branch
|
Contributor
|
this looks good to me |
dati18
reviewed
Jul 22, 2024
| working-directory: ui | ||
|
|
||
| - run: docker compose exec -it ui npm run test:e2e | ||
| working-directory: ui |
Contributor
There was a problem hiding this comment.
Do we need to take the setup down ie. docker compose down?
Contributor
Author
There was a problem hiding this comment.
Not that I'm aware of. The GitHub action environment is removed when the job is finished.
| start_period: 0s | ||
| extra_hosts: | ||
| - "host.docker.internal:host-gateway" | ||
|
|
Contributor
There was a problem hiding this comment.
Do we need Chrome tests also?
Contributor
Author
There was a problem hiding this comment.
That would have to be a separate ticket and patch.
dati18
approved these changes
Jul 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.