Optimize shutdown #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 1, 2019 17:54
…roduce aem_cms_stop_timeout_seconds to control kill timeout
…tes with custom ones
Contributor
Author
|
I executed a manual test with 100 restarts using the wcm_io_devops.aem_service role and the sysvinit/upstart solution worked without any inconsistent restart. I switched our CI to this branch and will now manually retest the systemd solution since here the stop mechanism still has some issues. |
added 2 commits
March 6, 2019 16:05
…re clean shutdown when systemd is the service manager
interatom
reviewed
Mar 11, 2019
added 5 commits
March 12, 2019 16:05
….sh enough time to complete.
Contributor
Author
|
@interatom i finalized the PR, please review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #4 we introduced a dependency to the synchronous mode from https://github.com/wcm-io-devops/conga-aem-definitions.
The Problem was that systemd was directly killing the process after calling the default Adobe AEM stop script.
With the now implemented solution the default AEM stop script is compatible with the systemd service.
@interatom: This is work in progress, but if you have time your feedback is appreciated.