Feature/rename s3 module #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
interatom
requested changes
Jun 18, 2019
meta/main.yml
Outdated
| issue_tracker_url: https://wcm-io.atlassian.net | ||
| license: Apache | ||
| min_ansible_version: 2.4 | ||
| min_ansible_version: 2.6 |
Contributor
There was a problem hiding this comment.
Looking at the module code it seems like it was renamed in 2.4, so do we really need that min. version bump?
Contributor
Author
There was a problem hiding this comment.
True. According to Ansible Docu: https://docs.ansible.com/ansible/latest/modules/aws_s3_module.html
In 2.4, this module has been renamed from s3 into aws_s3.
will change the min version back to 2.4.
Contributor
Author
There was a problem hiding this comment.
done. corrected the ansible version also in README
Contributor
|
Merged, thanks |
This was referenced Jun 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed s3 module to aws_s3. the module has been renamed since ansible 2.6