Update Gradle Wrapper scripts #660
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdullaer
reviewed
Apr 23, 2020
gradle.properties
Outdated
| # https://developer.android.com/topic/libraries/support-library/androidx-rn | ||
| android.useAndroidX=true | ||
| # Automatically convert third-party libraries to use AndroidX | ||
| android.enableJetifier=true |
Owner
There was a problem hiding this comment.
I'm not sure I want the behaviour of android.enableJetifier. It's often hard enough to reproduce issues as it is.
Contributor
Author
There was a problem hiding this comment.
Hi @wdullaer - Oh that's interesting.. Do you maybe have a link to more information on the behavior you mentioned? I have not seen any issues with it, and it's part of the default template of Android Studio. I'm also curious to find out if there are problems. Thanks!
Contributor
Author
There was a problem hiding this comment.
If you don't mind can you briefly let us know what kind of issues you were having with this statement set to true? Thanks!
friederbluemle
force-pushed
the
update-gradle-scripts
branch
from
8303e96 to
b52b5ca
Compare
Contributor
Author
|
Rebased and also disabled the Jetifier statement (see @wdullaer's comment above). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just the remaining scripts standardizations to the Gradle related scripts from #625 (after the main update was done in 8fb53c2). These are the verbatim formats of the files as generated by Android Studio (
gradle.properties), as well as Gradle (wrapper scripts).