fix: use vite build in prepare script to avoid devDependency requirement#28
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe prepare script in package.json was updated to invoke Vite's build command directly instead of routing through npm scripts. This is a single-line modification to the build invocation mechanism executed during npm package preparation. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
preparescript fromnpm run build(tsc && vite build) tovite builddirectlytscrequires devDependencies (e.g.minimatchtype definitions) which aren't installed for git dependenciesvite buildalone produces thedist/output that consuming projects needTest plan
npm install weDevsOfficial/tail-react#fix/prepare-script-vite-build) and verifydist/is built without errorsnpm installfrom the registry still works as expectedSummary by CodeRabbit