Skip to content

Fix for key not being saved with custom fields on services#390

Merged
apricot13 merged 2 commits intodevelopfrom
fix/key-not-saved-for-custom-fields
Sep 19, 2025
Merged

Fix for key not being saved with custom fields on services#390
apricot13 merged 2 commits intodevelopfrom
fix/key-not-saved-for-custom-fields

Conversation

@apricot13
Copy link
Member

Previously we stopped the custom fields being initialised by both key and label but that meant that key now wasn't being set when services were saved.

This PR:

  • Includes the current value of key when a custom field is saved
  • Adds in some more tests around the custom fields

@codecov
Copy link

codecov bot commented Sep 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.41%. Comparing base (fb841aa) to head (5eff51b).
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #390   +/-   ##
========================================
  Coverage    57.41%   57.41%           
========================================
  Files          125      125           
  Lines         2898     2898           
========================================
  Hits          1664     1664           
  Misses        1234     1234           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@apricot13 apricot13 merged commit 4cd9b87 into develop Sep 19, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant