Merged
Conversation
Owner
Author
|
METADATA_JOB_REQUEST_V1 Please update Rust metadata files for this PR. Submit the result directly to GitHub (commit) without asking for toggles or confirmations. Rules:
Targets: Modified:
Deleted: |
|
Summary
Testing
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
retainmethod.StringRecordwhile reusing the byte-level representation for performance.Description
pub fn retain<F>(&mut self, keep: F)toByteRecordthat compacts fields in-place by copying kept fields and updatingbounds.lenandbounds.endsaccordingly.pub fn retain<F>(&mut self, keep: F)toStringRecordwhich delegates to the underlying byte-levelretainand converts slices to&strwithunsafe { str::from_utf8_unchecked(...) }for predicate calls.trim_ascii_rangeandtrim_unicode_range) and switched trimming implementations to operate in-place usingcopy_withinand write indices.retain_fieldsto bothsrc/byte_record.rsandsrc/string_record.rsto verify retention behavior alongside existing trimming tests.Testing
retain_fieldsinsrc/byte_record.rsandsrc/string_record.rscovering typical retention scenarios.trimand other record invariants were left intact.cargo testwas not run).Codex Task