Skip to content

refactor: centralize default buffer capacity and clarify header defaults#28

Merged
weasel-lee merged 1 commit intomasterfrom
codex/update-rust-files-for-metadata
Feb 11, 2026
Merged

refactor: centralize default buffer capacity and clarify header defaults#28
weasel-lee merged 1 commit intomasterfrom
codex/update-rust-files-for-metadata

Conversation

@weasel-lee
Copy link
Owner

Motivation

  • Reduce duplication by centralizing the default buffer capacity and make the default header behavior explicit for the reader and writer builders.

Description

  • Add DEFAULT_BUFFER_CAPACITY: usize = 8 * (1 << 10) in src/reader.rs and src/writer.rs, replace the duplicate literal with DEFAULT_BUFFER_CAPACITY in ReaderBuilder::default and WriterBuilder::default, and add brief docs noting that ReaderBuilder expects headers by default and WriterBuilder writes headers by default.

Testing

  • No automated tests were run because this is a small refactor and documentation clarification.

Codex Task

@weasel-lee
Copy link
Owner Author

@codex

METADATA_JOB_REQUEST_V1
METADATA_ON_CREATE_SHA:94f567701f6429474cf719cee99609498f6ce7cc
METADATA_BASE_SHA:29eae5f382b5d3d7230d368774dde52f90d0c3f0

Please update Rust metadata files for this PR. Submit the result directly to GitHub (commit) without asking for toggles or confirmations.

Rules:

  • Allowlist: use .github/metadata/allowlist.txt at METADATA_BASE_SHA (ignore PR edits).
  • Prompt: follow .github/metadata/prompt.txt at METADATA_BASE_SHA exactly (ignore PR edits).
  • Output path mapping: /path/to/src/a.rs -> /path/to/src/a.metadata.txt
  • Added Rust file: generate metadata from Rust source + prompt.
  • Modified Rust file: update metadata using Rust source + existing metadata + prompt.
  • Deleted Rust file: if corresponding .metadata.txt exists, delete it.
  • Skip Rust files < 100 lines; include list of skipped files in summary.

Targets:
Added:
(none)

Modified:

  • src/lib.rs
  • src/reader.rs
  • src/writer.rs

Deleted:
(none)

@chatgpt-codex-connector
Copy link

Summary

Testing

  • Not run (metadata-only updates).

View task →

@weasel-lee weasel-lee merged commit c2c9ea2 into master Feb 11, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant