Update puget to 1.3.2 to support Babashka#25
Closed
filipesilva wants to merge 1 commit into
Closed
Conversation
Fix weavejester#21 (comment) This does not fix weavejester#21 proper though, it just allows it to run in Babashka.
Closed
Owner
|
Can you explain why it doesn't fix #21? |
Author
|
@weavejester #21 is actually about how and how @borkdude suggested he could look into improving this, if there was interest on your part. This PR is about how using hashp with babashka now fails due to Clojure 1.12.0 changes. Notice the same exec fails now that I've now removed the forced puget version: |
Author
|
This is also related to #23. But as far as I can tell that issue cannot be reproduced with 1.12: |
Author
|
Heya, I saw that 1c04e35 effects dependency update, so closing this PR. Cheers, and thanks for the great libs! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #21 (comment)
This does not fix #21 proper though, it just allows it to run in Babashka.