Rework API fields for nodegroup SGs

[errordeveloper]

Description

• closes ensure all config fields that can be set are handled appropriately #425
• closes shared security group is disabled by default when using config file #465

Checklist

• Code compiles correctly (i.e make build)
• Added tests that cover your change (if possible)
• All tests passing (i.e. make test)
• Added/modified documentation as required (such as the README)
• Added yourself to the humans.txt file

[errordeveloper]

@dlespiau this is still WIP, but I'd like to hear your feedback on the API change itself.

[errordeveloper]

@rndstr FYI

[dlespiau]

I guess it's to allow disabling the default SGs. Seems fine to me.

[errordeveloper]

Yes, it is to disable SG creation and allow passing pre-existing SGs only.

…

On Thu, 24 Jan 2019, 6:16 pm Damien Lespiau ***@***.*** wrote: I guess it's to allow disabling the default SGs. Seems fine to me. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#460 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAPWS2SIm0TZINVSD_xdzTE-xZj3A-Mqks5vGfhygaJpZM4aRZa6> .

[errordeveloper]

Will also need to address #465.

[errordeveloper]

I think it'd be good to also amend nodegroup check function to detect clusters that were affected by #465 and give user a warning.