Merged
Conversation
bigkevmcd
force-pushed
the
dont-set-ownership-namespaces
branch
from
0d0aa87 to
11972e4
Compare
A bug creating namespaces because the service account is namespaced scoped, and we can't set the ownership.
bigkevmcd
force-pushed
the
dont-set-ownership-namespaces
branch
from
11972e4 to
cfb8e79
Compare
foot
reviewed
Mar 14, 2023
| if err := controllerutil.SetOwnerReference(gitOpsSet, newResource, r.Scheme); err != nil { | ||
| return nil, fmt.Errorf("failed to set ownership: %w", err) | ||
| // cluster-scoped resources must not have a namespace-scoped owner | ||
| if newResource.GetKind() != "Namespace" { |
Collaborator
There was a problem hiding this comment.
I think we talked about this recently, but a shame there doesn't seem to be an isNamespacedObject helper.
Collaborator
Author
There was a problem hiding this comment.
Good idea, I'll sort that out :-)
Collaborator
There was a problem hiding this comment.
I'm curious! It sounds like a tricky one.. even namespaces/clusteroles seem to able to have namespaces.
This reduces our checks on "Namespace" resources.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can't set ownership for resources that are global resources.