Skip to content

Update templates used to generate API docs#45

Merged
AlinaGoaga merged 6 commits intomainfrom
update-api-gen-templates
Mar 15, 2023
Merged

Update templates used to generate API docs#45
AlinaGoaga merged 6 commits intomainfrom
update-api-gen-templates

Conversation

@AlinaGoaga
Copy link
Copy Markdown
Contributor

No description provided.

@AlinaGoaga AlinaGoaga marked this pull request as ready for review March 14, 2023 15:53
@AlinaGoaga AlinaGoaga requested a review from bigkevmcd March 14, 2023 15:58
Comment thread api/v1alpha1/inventory.go Outdated
type ResourceRef struct {
// ID is the string representation of the Kubernetes resource object's metadata,
// in the format '<namespace>_<name>_<group>_<kind>'.
// in the format 'namespace_name_group_kind'.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is a desirable change?

I'd like to keep the same as the upstream for this https://github.com/fluxcd/kustomize-controller/blob/main/api/v1beta2/inventory_types.go#L28

Copy link
Copy Markdown
Contributor Author

@AlinaGoaga AlinaGoaga Mar 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I use the generated documents in docusaurus it thinks those are html tags so it doesn't build 😅 . We can replace it after generation like in the example you had earlier?

Comment thread docs/api/source.md
@foot
Copy link
Copy Markdown
Collaborator

foot commented Mar 15, 2023

Looking great! Adding some comments just before the GitOpsSet type in gitopssets_types.go like this:

//+genclient
//+genclient:Namespaced

as they did in the source-controller PR https://github.com/fluxcd/source-controller/pull/63/files#diff-b1b8367d38c32920880bbf7147e892f5f8d6bc59d0f64a2c0ffeed559f9a4888R150-R151 highlights the resource types you can create and brings the GitOpSet Definition up to the top which is neat.

Copy link
Copy Markdown
Collaborator

@foot foot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 L G T M

@AlinaGoaga AlinaGoaga merged commit de743e4 into main Mar 15, 2023
@bigkevmcd bigkevmcd deleted the update-api-gen-templates branch June 20, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants