Cleanup cross-namespace resources from the inventory

[bigkevmcd]

This adds a finalizer and removes the resources recorded in the inventory from the cluster.

[foot]

Finalizer Added After Deletion Timestamp Set: If a resource is marked for deletion (i.e., its deletion timestamp is set) before a finalizer is added, the finalizer will never be run because the resource is already in the process of being deleted. To avoid this, controllers should add finalizers as soon as the resource is created.

This one?

[foot]

If something is suspended, and then deleted, we don't clean up? (Maybe we chatted about this already..)

[foot]

Ah yeah, maybe we can document this behaviour somewhere, (I couldn't find anything in the flux docs so far though).

[foot]

Ah, w/ ownerRefs can you avoid this wait?...

• ownerRefs: parent immediately deleted, dependants GC'd
• finalizer: .. all the stuff we're implementing here.

[bigkevmcd]

Yip, this is how it works.

With a finalizer the resource isn't deleted until there are no finalizers left on the resource, and it's on us to remove the resources.

[foot]

Nice helpers here

[foot]

Tested it a bit, works great 💯 !

Only didn't work for:

• load gs[0]
• delete configmaps manually
• delete gitopsset
• gets stuck, workaround: manually delete finalizer

This is rare, I sort of got it into this state by commenting out the namespace section as below, which removed the namespaces, (and so the configmaps), but the inv still had the configmaps.

Could we check for NotFound errors coming back from Delete? Not sure thats supported there. Anyway, lgtm!

[0]

apiVersion: templates.weave.works/v1alpha1
kind: GitOpsSet
metadata:
  name: gitopsset-configmaps
  namespace: default
spec:
  generators:
    - list:
        elements:
          - env: dev
            team: dev-team
          - env: production
            team: ops-team
          - env: staging
            team: ops-team
  templates:
    # - content:
    #     kind: Namespace
    #     apiVersion: v1
    #     metadata:
    #       name: "{{ .Element.env }}"
    - content:
        kind: ConfigMap
        apiVersion: v1
        metadata:
          name: "{{ .Element.env }}-info-configmap"
          namespace: "{{ .Element.env }}"
        spec:
          data:
            team: "{{ .Element.team }}"
            env: "{{ .Element.env }}"
            description: "This is a configmap for the {{ .Element.env }} environment"

[foot]

💯