Merged
Conversation
- Also incidentally add support for templating objects - Convert RawExtension back to YAML bytes before rendering - This re-escapes quotes introduced when gitopssets are converted to JSON - This technique is used in GitopsTemplates too
.. into other yaml types
bigkevmcd
approved these changes
Apr 21, 2023
Collaborator
bigkevmcd
left a comment
bigkevmcd
left a comment
There was a problem hiding this comment.
Looks good, nice work!
Co-authored-by: Kevin McDermott <kevin@weave.works>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caveats:
Strings that look like numbers will now become numbers, workarounds:{ version: "1.21" }->{ version: "{{ \"1.21\" | quote }}" }