Merged
Conversation
foot
reviewed
May 17, 2023
| } | ||
|
|
||
| if err := k8sClient.Delete(ctx, u); err != nil { | ||
| if err := client.IgnoreNotFound(k8sClient.Delete(ctx, u)); err != nil { |
Collaborator
There was a problem hiding this comment.
Neat, haven't seen this helper before.
Is this change related to this PR? (Its still nice to have! It will help with hanging finalizers + missing resources?)
Collaborator
Author
There was a problem hiding this comment.
I added it because the tests were failing trying to remove the GitOpsSet because of the missing ConfigMap.
This updates the predicates for updates to reconcile when the Reconciliation annotation is added.
bigkevmcd
force-pushed
the
add-annotation-predicate
branch
from
361d7d0 to
f42282c
Compare
foot
reviewed
May 17, 2023
| g.Eventually(func() bool { | ||
| log.Println("checking for the recreated object") | ||
| return testEnv.Get(ctx, client.ObjectKey{Name: "engineering-prod-cm", Namespace: "default"}, &cm) == nil | ||
| }, timeout).Should(gomega.BeTrue()) |
Collaborator
There was a problem hiding this comment.
🧠 , smart.
We could also check that gitOpsSet.Status.LastHandledReconcileAt has been set?
foot
approved these changes
May 17, 2023
Collaborator
foot
left a comment
foot
left a comment
There was a problem hiding this comment.
💯
Amazing, sync button working the EE UI too 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the predicates for updates to reconcile when the Reconciliation annotation is added.