Expose app version number at /api#148
Merged
tomwilkie merged 4 commits intoweaveworks:masterfrom Jun 3, 2015
Merged
Conversation
Contributor
|
LGTM Not this displaying this for now. |
Contributor
Author
|
Yes yes, baby steps... |
Contributor
Author
|
This is for #145 |
Contributor
|
What's the concrete use case? I want to avoid adding things to the API because we might want to have them in the future, maybe. |
Contributor
Author
|
This is to show the app version in the UI, for when people file bug reports. |
Contributor
Author
|
@davkal PTAL |
app/router.go
Outdated
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Contributor
|
Also I'd propose the following patch: diff --git a/Makefile b/Makefile
index c2245b2..c171d4f 100644
--- a/Makefile
+++ b/Makefile
@@ -11,7 +11,7 @@ SCOPE_IMAGE=$(DOCKERHUB_USER)/scope
SCOPE_EXPORT=scope.tar
SCOPE_UI_BUILD_EXPORT=scope_ui_build.tar
SCOPE_UI_BUILD_IMAGE=$(DOCKERHUB_USER)/scope-ui-build
-SCOPE_VERSION=$(shell git rev-parse HEAD)
+SCOPE_VERSION=$(shell git rev-parse --short HEAD)
all: $(SCOPE_EXPORT) |
Contributor
Author
|
Good suggestions. I'll hold off for @davkal as there are a bunch of UI changes too. |
Contributor
|
Let's move this to the right and make it a bit paler: diff --git a/client/app/styles/main.less b/client/app/styles/main.less
index 4f9cfa4..6a06eb6 100644
--- a/client/app/styles/main.less
+++ b/client/app/styles/main.less
@@ -58,11 +58,11 @@ body {
.footer {
position: absolute;
- bottom: 32px;
- padding-left: 64px;
- width: 100%;
- height: 1em;
+ bottom: 16px;
+ right: 48px;
z-index: 20;
+ color: @text-tertiary-color;
+ font-size: 85%;
}
.logo { |
added 4 commits
June 3, 2015 13:21
…e shorter version string when building for source.
Contributor
|
Yeah, rest looks GTM |
tomwilkie
added a commit
that referenced
this pull request
Jun 3, 2015
Expose app version number at /api
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm thinking we might want to expose a bunch more stuff at /api, such as what probe addresses we're connected to, what version those probes are etc.