Merged
Conversation
foot
approved these changes
Jun 12, 2018
Contributor
foot
left a comment
foot
left a comment
There was a problem hiding this comment.
It doesn't filter by namespace and the deployment ticks don't match the color of the deployment they represent.
This is really cool. 👌 LGTM.
| } | ||
|
|
||
| function mapStateToProps(state, { params }) { | ||
| const scopeState = state.scope || state; |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Contributor
Author
Related to https://github.com/weaveworks/service-ui/issues/1358.
Not sure how to address that at the moment, but it should probably go into a separate issue :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/weaveworks/service-ui/issues/2614 (affects only Scope in Weave Cloud).
Reuses a lot of code from
<TimeTravelWrapper />in Service UI - @foot and I had a discussion about converging those two, but that's a separate issue.Other changes
ui-componentsv0.4.82->v0.4.95z-index: $layer-fronton the whole header