Skip to content
This repository was archived by the owner on Jun 20, 2024. It is now read-only.
This repository was archived by the owner on Jun 20, 2024. It is now read-only.

clock: protect field access with lock to avoid possible data race #3984

@yanke-xu

Description

@yanke-xu

Fixed inconsistency and also potential data race in weave/vendor/k8s.io/apimachinery/pkg/util/clock/clock.go:
f.waiter is read/written 4 times in weave/vendor/k8s.io/apimachinery/pkg/util/clock/clock.go; 3 out of 4 times it is protected by f.fakeClock.lock/f,lock; 1 out of 4 times it is read without a Lock, which is in func C on L317.
A data race may happen when C() and other func like Stop() are called in parallel.

In order to avoid potential data race here, I use f.fakeClock.lock.RLock(); defer f.fakeClock.lock.RUnlock() to make sure that all usages of items is in critical section.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions