Pin the version of docker-py image in testing#1360
Conversation
6b2bf0d to
3a51c96
Compare
|
This is a recipe for us missing important changes to the Docker API that break the proxy, so negates half of the purpose of running this test suite in the first place (the other is to catch breaking changes in the proxy). So I don't think we should do this. Hopefully the root cause of these failures can be addressed instead. |
|
My impression is that they do run CI, but it was not covering the same cases we rely on. |
We are not doing anything unusual; just run the integration test suite. That should be made part of the docker-py CI. |
At the time of writing, all smoke-test runs are failing because of a bug in docker-py.
This change pins the version to (a) work round this and (b) avoid surprises in future.
We should update the pinned version periodically to ensure we keep up with the Docker API.
The image we use,
joffrey/docker-py, has very few tags, and no recent ones work with weave's smoke-tests, so I created a new imageweaveworks/docker-py:pinned, built from docker/docker-py@8ba85ac