Skip to content
This repository was archived by the owner on Jun 20, 2024. It is now read-only.

Pin the version of docker-py image in testing#1360

Closed
bboreham wants to merge 1 commit intomasterfrom
pin-py-test-version
Closed

Pin the version of docker-py image in testing#1360
bboreham wants to merge 1 commit intomasterfrom
pin-py-test-version

Conversation

@bboreham
Copy link
Contributor

At the time of writing, all smoke-test runs are failing because of a bug in docker-py.
This change pins the version to (a) work round this and (b) avoid surprises in future.
We should update the pinned version periodically to ensure we keep up with the Docker API.

The image we use, joffrey/docker-py, has very few tags, and no recent ones work with weave's smoke-tests, so I created a new image weaveworks/docker-py:pinned, built from docker/docker-py@8ba85ac

@rade
Copy link
Member

rade commented Aug 27, 2015

This is a recipe for us missing important changes to the Docker API that break the proxy, so negates half of the purpose of running this test suite in the first place (the other is to catch breaking changes in the proxy).

So I don't think we should do this. Hopefully the root cause of these failures can be addressed instead.

@bboreham
Copy link
Contributor Author

My impression is that they do run CI, but it was not covering the same cases we rely on.
A subsequent change, docker/docker-py@b5f1e64, broke our use of the test in a different way, and I couldn't quickly figure out how to recover from that. I thought I'd let their changes settle down and then get it back in shape.

@rade
Copy link
Member

rade commented Aug 27, 2015

My impression is that they do run CI, but it was not covering the same cases we rely on.

We are not doing anything unusual; just run the integration test suite. That should be made part of the docker-py CI.

@bboreham bboreham closed this Aug 27, 2015
@rade rade modified the milestone: n/a Aug 29, 2015
@rade rade deleted the pin-py-test-version branch August 31, 2015 09:50
@bboreham bboreham mentioned this pull request Jun 3, 2016
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants