This repository was archived by the owner on Jun 20, 2024. It is now read-only.
Hold DNS entries sorted case-insensitively until just before sending#1615
Merged
Hold DNS entries sorted case-insensitively until just before sending#1615
Conversation
bboreham
force-pushed
the
1603-resort-in-encode
branch
from
0cb6a9b to
fa2a5ab
Compare
bboreham
force-pushed
the
1603-resort-in-encode
branch
2 times, most recently
from
609d458 to
6ee8e76
Compare
Contributor
Author
|
Yay! Unit tests passed! |
bboreham
force-pushed
the
1603-resort-in-encode
branch
from
6ee8e76 to
2bf895a
Compare
nameserver/entry_test.go
Outdated
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
reduce mock gossip timer to 2 seconds to trigger more often during tests.
… when we re-sort case-sensitively in Encode()
…ting it every time
rade
force-pushed
the
1603-resort-in-encode
branch
from
2bf895a to
b80c134
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of sorting when creating the outbound GossipData object, we sort in
Encode().Fixes #1603 and #1610
Since the extended unit tests revealed that it is expensive to re-compute
ToLower()every time we look at a hostname, this PR also changes this to compute the lower-case version on entry to the data structure and hold on to it thereafter.(replacement for #1611 which was against the wrong branch)