This repository was archived by the owner on Jun 20, 2024. It is now read-only.
Closed
Conversation
rade
changed the title
| // FIXME looks like plugins-helpers does not allow a single | ||
| // mux to serve multiple APIs. This is problematic, since ATM | ||
| // we only have one socket. | ||
| ipamapi.NewHandler(ipamDriver).Serve(socket) |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
rade
changed the title
rade
force-pushed
the
1986-depend-on-plugin-helpers
branch
from
caed4a7 to
4ea5495
Compare
Contributor
|
We agreed IRL to close this as the Docker plugins-helpers framework is incompatible with using a single socket. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO
Fixes #1986.