Skip to content
This repository was archived by the owner on Jun 20, 2024. It is now read-only.

[WIP] 2017: AWSVPC#2091

Closed
brb wants to merge 63 commits intomasterfrom
issues/2017-awsvpc-wip
Closed

[WIP] 2017: AWSVPC#2091
brb wants to merge 63 commits intomasterfrom
issues/2017-awsvpc-wip

Conversation

@brb
Copy link
Contributor

@brb brb commented Mar 23, 2016

NOTE: DO NOT MERGE

I am opening this PR to get your early feedback.

The PR covers partly #2017 and #2018

@brb brb force-pushed the issues/2017-awsvpc-wip branch from a344dd6 to a1c081b Compare April 4, 2016 12:07
bboreham
bboreham reviewed Apr 28, 2016
View reviewed changes
ipam/ring/ring.go Outdated
r.Seeds = peers
}

// createEntriesCIDR subdivides the [from,to) (CIDR) range for the given peers

This comment was marked as abuse.

Sign in to view

@rade rade assigned brb Apr 29, 2016
@brb brb force-pushed the issues/2017-awsvpc-wip branch 3 times, most recently from adb8959 to 46bc235 Compare May 16, 2016 12:55
@brb brb force-pushed the issues/2017-awsvpc-wip branch 2 times, most recently from 30ea0a1 to 7cf22f0 Compare May 17, 2016 10:55
bboreham
bboreham reviewed May 19, 2016
View reviewed changes
weave Outdated
eval "set -- $ARGS"

create_bridge
docker_bridge_ip

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

@bboreham
Copy link
Contributor

bboreham commented May 19, 2016

Need to adjust weave status so it doesn't leave the connections as pending:

Connections: 1 (1 pending)
      Peers: 2 (with 2 pending connections)

Maybe by instantiating awsvpc as a different kind of connection, as discussed.

bboreham
bboreham reviewed May 19, 2016
View reviewed changes
test/aws.sh
$AWSCLI ec2 authorize-security-group-ingress \
--group-name "$SEC_GROUP_NAME" \
--protocol tcp --port 2375 \
--cidr "0.0.0.0/0"

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

@brb brb force-pushed the issues/2017-awsvpc-wip branch 3 times, most recently from 5e21073 to 6208895 Compare May 23, 2016 12:29
bboreham
bboreham reviewed May 25, 2016
View reviewed changes
prog/weaver/Dockerfile Outdated
@@ -1,6 +1,7 @@
FROM scratch
FROM gliderlabs/alpine

This comment was marked as abuse.

Sign in to view

@brb brb force-pushed the issues/2017-awsvpc-wip branch 5 times, most recently from 4201ce2 to 225ae77 Compare May 26, 2016 13:50
@brb brb force-pushed the issues/2017-awsvpc-wip branch from 35c8189 to 44eec32 Compare June 7, 2016 10:31
@bboreham
Copy link
Contributor

bboreham commented Jun 9, 2016

merged as #2341

@bboreham bboreham closed this Jun 9, 2016
@awh awh added this to the n/a milestone Jun 9, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@brb brb

Labels

None yet

Projects

None yet

Milestone

n/a

Development

Successfully merging this pull request may close these issues.

4 participants

@brb @bboreham @rade @awh