This repository was archived by the owner on Jun 20, 2024. It is now read-only.
Docker 1.12: handle daemon named 'dockerd'#2380
Closed
Conversation
Member
|
This should be on the 1.5 branch. |
Contributor
|
LGTM. Quick aside - this https://github.com/weaveworks/weave/pull/2380/files#diff-5fb26b2385c2ea3455765e854c85c607R50
Did you want to retarget this at the 1.5 branch? |
Contributor
Author
|
I imagine that However, if we did make it break the loop, I suspect we could mistake a |
This means when Docker says "101 UPGRADED" the proxy will say the same, instead of "200 OK". Docker 1.12 barfs if you do that.
Contributor
Author
|
Replaced by #2382 on 1.5 branch |
Contributor
Author
|
Changed my mind: the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2379