chore: pre-export fixes (split out from #324)#330
Merged
mpartipilo merged 5 commits intomainfrom Apr 27, 2026
Merged
Conversation
Test_DeleteAll_Operations still flakes occasionally on main (#325 reduced but did not eliminate the race). The server flips operations to ScheduledForDelete and clears them on its own cadence — the polling loop shouldn't wait for the row to disappear, since the deletion is already committed. Filter out ScheduledForDelete entries from the "remaining" count so the test exits as soon as every op has been marked. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
BatchState was introduced in #305 with three values (Open, InFlight, Closed). Day-one drift: the same PR's docs (Batch/README.md, docs/BATCH_API_USAGE.md) and PublicAPI.Unshipped.txt listed a fourth Aborted = 3 value that the C# enum has never had. The RS0017 analyzer warning has been firing on main as a result. Remove the phantom value from all three places. No code path references it. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…nBase Two correctness fixes plus minor cleanup: - Mark _isCompleted/_isSuccessful/_isCanceled volatile. They are read from a background polling task and a foreground waiter without locks; the JIT could otherwise hoist the read out of the loop and never observe the flip. - Scope the linked CancellationTokenSource in WaitForCompletionInternal with `using var`. The previous code created the linked CTS, kept only the token, and let the source go un-disposed every wait. - Early-return Task.CompletedTask from StartBackgroundRefresh when the operation is already complete, avoiding a no-op task allocation. - Drop the explicit ThrowIfCancellationRequested at the top of the wait loop. The while-condition already exits cleanly on cancellation, and the prior throw conflicted with the post-completion catch clause that intentionally swallows OCE. No public-API change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
WeaviateVectorStoreCollection.HybridSearchAsync<TInput> was declared with `public new`, implying it shadowed a base member. The base type VectorStoreCollection has no HybridSearchAsync<TInput> overload, so `new` was incorrect and produced a CS0109 "no suitable member found to override" warning. Remove `new`. The override is now plain. PublicAPI.Unshipped.txt picks up the now-explicit signature. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Document the regeneration pipeline (tools/openapi_sync.sh and tools/gen_rest_dto.sh) plus the Liquid template override pattern in src/Weaviate.Client/Rest/Schema/Templates/. Hand-editing Models.g.cs has bitten contributors before; mark it as auto-generated. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
Summary - Weaviate C# Client CoverageSummary
CoverageWeaviate.Client - 39.9%
Weaviate.Client.Analyzers - 0%
Weaviate.Client.VectorData - 50.3%
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Five small fixes carved out of #324 (Collection Export) so that PR can shrink to export-only. Each fix is independent and unrelated to the export feature itself; they had drifted into the export branch over the course of development. Splitting them out per @dirkkul's review on #324 (`why this change?` on `Batch/README.md`, `unrelated change?` on `TestReplication.cs`).
Commits
Test plan
Follow-up
After this lands, #324 will be rebased onto main so its diff is export-only, and the `fileType` / `Delete-on-409` review fixes will be applied there.
🤖 Generated with Claude Code