-
Notifications
You must be signed in to change notification settings - Fork 15
Add multi2multivec-weaviate details #323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Infrastructure as Code | View in Orca | ||
| SAST | View in Orca | ||
| Secrets | View in Orca | ||
| Vulnerabilities | View in Orca |
| imageField: 'doc_page', | ||
| model: 'ModernVBERT/colmodernvbert', | ||
| encoding: weaviate.configure.vectorIndex.multiVector.encoding.muvera({ | ||
| ksim: 4, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shall we state that these muvera params are optional like in other examples, so users don't need to think about them too much?
we could also remove name (as it's only single vectorizer) and model (to utilize default) to simplify. Especially as query examples below in the documents use default vector (not named vector).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good points, I will try to change the vector naming in all model provider pages at some point to make the examples consistent.
| # The model provider integration will automatically vectorize the object | ||
| batch.add_object( | ||
| properties=weaviate_obj, | ||
| # vector=vector # Optionally provide a pre-obtained vector |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we shouldn't suggest passing a vector, cause the module should vectorize the it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would potentially leave it as there is an option of vectorizing some of the objects and import vectors for others.
What's being changed:
colmodernVBERT) and module (multi2multivec-weaviate) in Weaviate EmbeddingsType of change:
How has this been tested?
yarn start