Add dedicated factory methods for Google Gemini vectorizer#545
Merged
Conversation
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Infrastructure as Code | View in Orca | ||
| SAST | View in Orca | ||
| Secrets | View in Orca | ||
| Vulnerabilities | View in Orca |
antas-marcin
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces dedicated factory method
Multi2VecGoogleVectorizer::geminithat provides configuration options tailored to the Gemini API.Additionally, we rename
-Googlemethods to-GoogleVertex(similarly to how we have it in thegenerate/module) and deprecate the older methods.There's a slight breaking change in that
Multi2VecGoogleVectorizer::vertexacceptsVertexBuilderand not the baseBuilder. This is necessary to exposeapiEndpointsetter for Vertex, but not for Gemini configuration. Users that use the lambda shorthand should not be affected at all; only explicit use of the builder type would need to be updated, e.g.: