Add --async_replication_config option to create/update collection by jfrancoa · Pull Request #164 · weaviate/weaviate-cli

jfrancoa · 2026-03-25T16:00:04Z

Summary

Add --async_replication_config key=value repeatable option to create collection and update collection commands
Exposes 14 async replication tuning parameters (max_workers, frequency, propagation_concurrency, etc.) from weaviate-python-client PR #1953
Uses a single repeatable option with key=value pairs instead of 14 individual flags to keep the CLI clean
Add parse_async_replication_config() helper in utils.py with key/value validation
Add unit tests for the parser and both create/update collection paths

Closes #163

Usage

# Create with async replication config
weaviate-cli create collection --collection MyCol --async_enabled \
  --async_replication_config max_workers=10 \
  --async_replication_config frequency=60 \
  --async_replication_config propagation_concurrency=4

# Update async replication config
weaviate-cli update collection --collection MyCol \
  --async_replication_config max_workers=20 \
  --async_replication_config propagation_batch_size=100

Test plan

make lint passes
make test passes (283/283)
Manual test with Weaviate >= v1.34.18

🤖 Generated with Claude Code

orca-security-eu

Orca Security Scan Summary

Status	Check	Issues by priority
Passed	Infrastructure as Code	0 0 0 0	View in Orca
Passed	SAST	0 0 0 0	View in Orca
Passed	Secrets	0 0 0 0	View in Orca
Passed	Vulnerabilities	0 0 0 0	View in Orca

Copilot

Pull request overview

Adds a new repeatable --async_replication_config key=value option to the CLI to expose async replication tuning parameters when creating/updating collections, including parsing/validation logic and unit tests to cover the new behavior.

Changes:

Introduces parse_async_replication_config() and a validated key allowlist for async replication tuning parameters.
Wires async_config into collection create/update replication config via the Python client configuration objects.
Adds unit tests for the parser and manager create/update paths; updates operating docs for the new option.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
`weaviate_cli/utils.py`	Adds allowlisted keys and a parser to convert repeatable `key=value` tuples into a validated dict of ints.
`weaviate_cli/managers/collection_manager.py`	Passes parsed async replication config into `wvc.Configure/Reconfigure.*.async_config(...)` when present.
`weaviate_cli/defaults.py`	Adds defaults entries for the new CLI option.
`weaviate_cli/commands/create.py`	Adds Click option and passes parsed async replication config into `CollectionManager.create_collection(...)`.
`weaviate_cli/commands/update.py`	Adds Click option and passes parsed async replication config into `CollectionManager.update_collection(...)`.
`test/unittests/test_utils.py`	Adds unit tests for the async replication config parser (happy path + error cases).
`test/unittests/test_managers/test_collection_manager.py`	Adds tests asserting `asyncConfig` is set/omitted on create/update replication config.
`.claude/skills/operating-weaviate-cli/references/collections.md`	Documents the new option and provides examples for create/update.
`.claude/skills/operating-weaviate-cli/SKILL.md`	Updates the “operating” skill docs with the new option and examples.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Expose the 14 async replication tuning parameters from weaviate-python-client PR #1953 via a single repeatable --async_replication_config key=value option. This avoids bloating the CLI with 14 individual flags while letting users configure any subset of parameters. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

- Reject --async_replication_config when --async_enabled is not set (create) - Reject --async_replication_config when --async_enabled is False (update) - Warn when server version is older than v1.36.0 - Generate Click help text from ASYNC_REPLICATION_CONFIG_KEYS constant - Add validation tests for both create and update paths Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

- Add --async_enabled prerequisite to help text, SKILL.md, and collections.md - Point weaviate-client dependency to jose/fix-async-repl-config-get branch - Update setup.cfg install_requires to match Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

- Add --async_enabled prerequisite to help text, SKILL.md, and collections.md - Point weaviate-client dependency to jose/fix-async-repl-config-get branch - Update setup.cfg install_requires to match - Change minimum version to 1.34.18 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Support "reset" keyword to revert all async replication settings to server defaults. Use `is not None` checks so empty dict (reset) is correctly forwarded as an empty async_config() call. Update version references to v1.34.18. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- Use ASYNC_REPLICATION_CONFIG_RESET constant in parser instead of literal - Remove unused async_replication_config field from CreateCollectionDefaults and UpdateCollectionDefaults - Reject --async_replication_config 'reset' on create (no semantics for new collections) - Tighten type annotations: tuple -> Tuple[str, ...] - Drop trivially-dead `if result else None` return - Add unit tests for old-version warning path (create + update) - Add unit test for update reset path asserting Reconfigure.Replication.async_config() is invoked with no kwargs Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- Let click.UsageError propagate from create_collection_cli so Click renders it as a proper usage error instead of being swallowed by except Exception - Clarify in ASYNC_REPLICATION_CONFIG_HELP that "reset" is update-only Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

jfrancoa · 2026-05-06T07:55:40Z

@copilot review

…to v1.36.0 everywhere Agent-Logs-Url: https://github.com/weaviate/weaviate-cli/sessions/712f888c-8664-4b19-8539-a7754385e328 Co-authored-by: jfrancoa <23482278+jfrancoa@users.noreply.github.com>

orca-security-eu Bot reviewed Mar 25, 2026

View reviewed changes

jfrancoa requested a review from Copilot March 25, 2026 16:04

Copilot started reviewing on behalf of jfrancoa March 25, 2026 16:06 View session

Copilot AI reviewed Mar 25, 2026

View reviewed changes

Comment thread weaviate_cli/managers/collection_manager.py

Comment thread weaviate_cli/commands/create.py Outdated

Comment thread weaviate_cli/commands/update.py Outdated

Comment thread weaviate_cli/managers/collection_manager.py

Comment thread weaviate_cli/managers/collection_manager.py

jfrancoa requested a review from Copilot March 25, 2026 20:52

Copilot started reviewing on behalf of jfrancoa March 25, 2026 20:53 View session

Copilot AI reviewed Mar 25, 2026

View reviewed changes

Comment thread weaviate_cli/utils.py Outdated

Comment thread weaviate_cli/managers/collection_manager.py

Comment thread .claude/skills/operating-weaviate-cli/references/collections.md Outdated

Comment thread .claude/skills/operating-weaviate-cli/SKILL.md Outdated

jfrancoa requested a review from Copilot March 26, 2026 13:53

Copilot started reviewing on behalf of jfrancoa March 26, 2026 13:54 View session

Copilot AI reviewed Mar 26, 2026

View reviewed changes

Comment thread setup.cfg Outdated

Comment thread requirements-dev.txt Outdated

Comment thread weaviate_cli/utils.py

jfrancoa force-pushed the jose/async-replication-collection-params branch from 68f553a to 9ebab2b Compare March 27, 2026 13:28

jfrancoa and others added 6 commits May 5, 2026 16:30

Update operating skill docs with --async_replication_config

5f5ab38

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

jfrancoa requested a review from Copilot May 5, 2026 15:37

Copilot started reviewing on behalf of jfrancoa May 5, 2026 15:38 View session

Copilot AI reviewed May 5, 2026

View reviewed changes

Comment thread weaviate_cli/utils.py

Comment thread weaviate_cli/utils.py

Comment thread weaviate_cli/managers/collection_manager.py

Comment thread weaviate_cli/defaults.py Outdated

jfrancoa force-pushed the jose/async-replication-collection-params branch from 9ebab2b to 5985492 Compare May 5, 2026 15:56

jfrancoa requested a review from Copilot May 5, 2026 15:57

Copilot started reviewing on behalf of jfrancoa May 5, 2026 15:58 View session

Copilot AI reviewed May 5, 2026

View reviewed changes

Copilot started work on behalf of jfrancoa May 6, 2026 07:55 View session

Fix version discrepancy: update async_replication_config min version …

9d530ac

…to v1.36.0 everywhere Agent-Logs-Url: https://github.com/weaviate/weaviate-cli/sessions/712f888c-8664-4b19-8539-a7754385e328 Co-authored-by: jfrancoa <23482278+jfrancoa@users.noreply.github.com>

Copilot finished work on behalf of jfrancoa May 6, 2026 08:00

jfrancoa merged commit fe9cdc8 into main May 7, 2026
18 checks passed

Conversation

jfrancoa commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Usage

Test plan

Uh oh!

orca-security-eu Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Orca Security Scan Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jfrancoa commented May 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jfrancoa commented Mar 25, 2026 •

edited

Loading

orca-security-eu Bot left a comment •

edited

Loading