Skip to content

Conversation

@cryo-zd
Copy link
Contributor

@cryo-zd cryo-zd commented Mar 15, 2025

What's being changed:

The example golang code for keyword searching could not run properly, we fix some syntax error so that it could work.

The error message of the original code is as follows:
./main.go:30:12: invalid composite literal type string
./main.go:31:3: label properties defined and not used
./main.go:31:15: non-name []string{…} on left side of :=
./main.go:32:11: assignment mismatch: 2 variables but client.GraphQL().Bm25ArgBuilder().WithQuery(query).WithProperties returns 1 value
./main.go:34:20: undefined: properties
./main.go:41:5: client.GraphQL().Get().WithClassName(className).WithFields(title, _additional).WithBm25 undefined (type *graphql.GetBuilder has no field or method WithBm25, but does have method WithBM25)

Type of change:

  • Documentation updates (non-breaking change to fix/update documentation)
  • Website updates (non-breaking change to update main page, company pages, pricing, etc)
  • Content updates – blog, podcast (non-breaking change to add/update content)
  • Bug fix (non-breaking change to fixes an issue with the site)
  • Feature or enhancements (non-breaking change to add functionality)

How Has This Been Tested?

  • GitHub action – automated build completed without errors
  • Local build - the site works as expected when running yarn start

note, you can run yarn verify-links to test site links locally

Copy link

@orca-security-eu orca-security-eu bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

@weaviate-git-bot
Copy link

To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge.

beep boop - the Weaviate bot 👋🤖

PS:
Are you already a member of the Weaviate Slack channel?

@cryo-zd
Copy link
Contributor Author

cryo-zd commented Mar 15, 2025

I agree with the CLA.

@g-despot
Copy link
Contributor

g-despot commented Apr 3, 2025

Thank you for the contribution 😄

@g-despot g-despot merged commit d230181 into weaviate:main Apr 3, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants