Skip to content

Conversation

@tsmith023
Copy link
Collaborator

Closes #1016

@tsmith023 tsmith023 requested a review from dirkkul July 24, 2024 14:12
@tsmith023 tsmith023 changed the title Parse the correct timeouts to httpx client Parse the correct timeouts to httpx client Jul 24, 2024
@dirkkul
Copy link
Collaborator

dirkkul commented Jul 24, 2024

test? 😆

@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 95.77465% with 3 lines in your changes missing coverage. Please review.

Project coverage is 94.45%. Comparing base (6234608) to head (4b20ef9).
Report is 27 commits behind head on main.

Files Patch % Lines
mock_tests/test_timeouts.py 88.23% 2 Missing ⚠️
mock_tests/conftest.py 96.77% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1206      +/-   ##
==========================================
+ Coverage   94.42%   94.45%   +0.03%     
==========================================
  Files         215      217       +2     
  Lines       20686    20750      +64     
==========================================
+ Hits        19533    19600      +67     
+ Misses       1153     1150       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsmith023 tsmith023 merged commit 29e8336 into main Jul 25, 2024
@tsmith023 tsmith023 deleted the connect/fix-parsing-of-timeouts branch July 25, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The Timeout(insert) parameter determines startup timeout threshold

4 participants