Skip to content

Improve flakiness of SSB tests#2015

Merged
tsmith023 merged 17 commits intomainfrom
chore/add-timeouts-to-batch-tests
Apr 20, 2026
Merged

Improve flakiness of SSB tests#2015
tsmith023 merged 17 commits intomainfrom
chore/add-timeouts-to-batch-tests

Conversation

@tsmith023
Copy link
Copy Markdown
Collaborator

@tsmith023 tsmith023 commented Apr 16, 2026

  • mark batch tests specifically with long timeouts
  • add timeouts to GH action jobs as a backup
  • dump full stack-trace on timeout detection to debug hangs in the CI
  • avoid long timeouts when putting to requests queue
  • add shutdown timeout to join/gather or bg threads/tasks
  • update inflight_{objs,refs} immediately before sending over wire

- mark batch tests specifically with long timeouts
- add timeouts to GH action jobs as a backup
- dump full stack-trace on timeout detection to debug hangs in the CI
@tsmith023 tsmith023 requested a review from dirkkul April 16, 2026 11:14
@tsmith023 tsmith023 requested a review from a team as a code owner April 16, 2026 11:14
Copy link
Copy Markdown

@orca-security-eu orca-security-eu Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 16, 2026

Codecov Report

❌ Patch coverage is 70.83333% with 49 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.82%. Comparing base (78fa5f7) to head (eddac53).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
mock_tests/conftest.py 33.33% 14 Missing ⚠️
weaviate/collections/batch/async_.py 62.16% 14 Missing ⚠️
weaviate/collections/batch/sync.py 70.27% 11 Missing ⚠️
conftest.py 68.75% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2015      +/-   ##
==========================================
- Coverage   87.95%   87.82%   -0.13%     
==========================================
  Files         280      282       +2     
  Lines       21664    21772     +108     
==========================================
+ Hits        19054    19121      +67     
- Misses       2610     2651      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tsmith023 tsmith023 changed the title Add pytest timeouts Improve flakiness of SSB tests Apr 20, 2026
@tsmith023 tsmith023 merged commit 6dce105 into main Apr 20, 2026
240 of 244 checks passed
@tsmith023 tsmith023 deleted the chore/add-timeouts-to-batch-tests branch April 20, 2026 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants