ParGroup call causing a maxium call stack error

[StephMc]

new Animation(topObjects[i], {left: ["100px", "600px"]}, 2);
new Animation(topObjects[i], {left: ["100px", "600px"]}, 2);
var parentAnimation = new ParGroup(document.animationTimeline.children);

The above code causes an error "Uncaught RangeError: Maximum call stack size exceeded"

[steveblock]

Thanks for the bug report Steph. Could you write a test that covers this situation (based on the code you have above) and submit a pull request? I'll try to fix the bug and will include the test when I do.

[steveblock]

The problem is that parentGroup tries to add itself as a child, causing an infinite recursion. This happens because when the underlying AnimationGroup is created, it is added to document.animationTimeline.children. When the ParGroup then tries to add all of the specified children from document.animationTimeline.children, it encounters itself. (There's an indexing subtlety which means we only hit this condition when the array of children initially has at least two members)

The fix is to take a copy of the array of children before creating the AnimationGroup, to avoid the effects of it being later modified.

[StephMc]

web-animations/web-animations-js#68

[steveblock]

Fixed with web-animations/web-animations-js@d10a587