Conversation
Member
|
Isn't it better to use a separate dedicated class for VERIFY PIN? See #84 |
Contributor
Author
It has separate struct? |
mrts
approved these changes
Feb 23, 2026
Closed
mrts
requested changes
Feb 23, 2026
| PCSC_CPP_DEFAULT_MOVE(VerifyApdu); | ||
| constexpr ~VerifyApdu() noexcept final { std::fill(d.begin(), d.end(), byte_type(0)); } | ||
| }; | ||
| return VerifyApdu {0x00, 0x20, 0x00, p2, std::move(pin)}; |
Member
There was a problem hiding this comment.
Slicing, because you return VerifyApdu by value from CommandApdu verify().
Contributor
Author
There was a problem hiding this comment.
There are no additional member variables?
Member
There was a problem hiding this comment.
Yeah, but the VerifyApdu destructor will not be called and CommandApdu destructor will be called instead because of slicing as far as I understand. Try printing something to stdout in VerifyApdu destructor to verify.
WE2-1055 Signed-off-by: Raul Metsma <raul@metsma.ee>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WE2-1055
Signed-off-by: Raul Metsma raul@metsma.ee