Skip to content

Fix authtoken signature validation #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kristelmerilain merged 4 commits into from
Jun 26, 2023
Merged

Fix authtoken signature validation #10

kristelmerilain merged 4 commits into from
Jun 26, 2023

Conversation

@Muzosh
Copy link
Contributor

@Muzosh Muzosh commented May 20, 2023

Code update for #5 and #9.

@Muzosh
Copy link
Contributor Author

Muzosh commented May 20, 2023 •
edited
Loading

Note for the unit test: I'm not really sure if these values can be left in the code. I had to use origin value 'https:/localhost:8443' as it was my work environment. I wasn't able to create valid signatures any other way.

EDIT: resolved

@Muzosh Muzosh marked this pull request as ready for review May 21, 2023 07:00
This was linked to issues Jun 26, 2023
Check for EC signature format needs to be added before trying to transcode it into DER #5
Closed
Check for authentication value signature does not cover all cases #9
Closed
@kristelmerilain kristelmerilain merged commit f619e57 into web-eid:main Jun 26, 2023
@Muzosh Muzosh deleted the fix-authtoken-validation branch June 26, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@metsma metsma metsma approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

3 participants

@Muzosh @metsma @kristelmerilain