fix(core): planning cache #1505
Conversation
✅ Deploy Preview for midscene ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let thinkingLevelToUse = opt?._thinkingLevel; | ||
| if (!thinkingLevelToUse && this.opts.aiActionContext) { |
There was a problem hiding this comment.
The aiAct options now only read opt._thinkingLevel, so any caller still passing the documented thinkingLevel flag has its request ignored and the method falls back to the medium/high defaults. For example, packages/web-integration/tests/ai/web/puppeteer/e2e.test.ts:42-44 still passes { thinkingLevel: 'high' }, which will now be treated as if no level was provided. This silently changes planning behaviour for consumers relying on that knob; please continue accepting the existing option or update the call sites.
Useful? React with 👍 / 👎.
| // Check if the modelFamily is valid | ||
| if (!MODEL_FAMILY_VALUES.includes(modelFamily as any)) { | ||
| throw new Error(`Invalid modelFamily: ${modelFamily}`); | ||
| throw new Error(`Invalid MIDSCENE_MODEL_FAMILY value: ${modelFamily}`); |
There was a problem hiding this comment.
The error message for invalid MIDSCENE_MODEL_FAMILY was changed to Invalid MIDSCENE_MODEL_FAMILY value: …, but packages/shared/tests/unit-test/env/parse.test.ts:52-54 still asserts the previous Invalid modelFamily: invalid. This change causes that unit test to fail and will break the test suite until the message or expectation is brought back into sync.
Useful? React with 👍 / 👎.
No description provided.